From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw38567 [PATCH v2 2/8] net/sfc/base: add a new means to control RSS hash
Date: Thu, 19 Apr 2018 18:42:30 +0200 (CEST) [thread overview]
Message-ID: <20180419164230.40647F987@dpdk.org> (raw)
In-Reply-To: <1524156112-28615-3-git-send-email-arybchenko@solarflare.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/38567
_coding style issues_
CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#191: FILE: drivers/net/sfc/base/efx.h:2178:
+extern __checkReturn efx_rc_t
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_entryp' - possible side-effects?
#224: FILE: drivers/net/sfc/base/efx_rx.c:312:
+#define LIST_FLAGS(_entryp, _class, _l4_hashing) \
+ do { \
+ if (_l4_hashing) \
+ *(_entryp++) = EFX_RX_HASH(_class, 4TUPLE); \
+ \
+ *(_entryp++) = EFX_RX_HASH(_class, 2TUPLE); \
+ *(_entryp++) = EFX_RX_HASH(_class, DISABLE); \
+ \
+ _NOTE(CONSTANTCONDITION) \
+ } while (B_FALSE)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_class' - possible side-effects?
#224: FILE: drivers/net/sfc/base/efx_rx.c:312:
+#define LIST_FLAGS(_entryp, _class, _l4_hashing) \
+ do { \
+ if (_l4_hashing) \
+ *(_entryp++) = EFX_RX_HASH(_class, 4TUPLE); \
+ \
+ *(_entryp++) = EFX_RX_HASH(_class, 2TUPLE); \
+ *(_entryp++) = EFX_RX_HASH(_class, DISABLE); \
+ \
+ _NOTE(CONSTANTCONDITION) \
+ } while (B_FALSE)
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#253: FILE: drivers/net/sfc/base/efx_rx.c:341:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#261: FILE: drivers/net/sfc/base/efx_rx.c:349:
+ return (rc);
total: 2 errors, 0 warnings, 3 checks, 320 lines checked
parent reply other threads:[~2018-04-19 16:42 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1524156112-28615-3-git-send-email-arybchenko@solarflare.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180419164230.40647F987@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=arybchenko@solarflare.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).