* [dpdk-test-report] |WARNING| pw38567 [PATCH v2 2/8] net/sfc/base: add a new means to control RSS hash
[not found] <1524156112-28615-3-git-send-email-arybchenko@solarflare.com>
@ 2018-04-19 16:42 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2018-04-19 16:42 UTC (permalink / raw)
To: test-report; +Cc: Andrew Rybchenko
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/38567
_coding style issues_
CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#191: FILE: drivers/net/sfc/base/efx.h:2178:
+extern __checkReturn efx_rc_t
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_entryp' - possible side-effects?
#224: FILE: drivers/net/sfc/base/efx_rx.c:312:
+#define LIST_FLAGS(_entryp, _class, _l4_hashing) \
+ do { \
+ if (_l4_hashing) \
+ *(_entryp++) = EFX_RX_HASH(_class, 4TUPLE); \
+ \
+ *(_entryp++) = EFX_RX_HASH(_class, 2TUPLE); \
+ *(_entryp++) = EFX_RX_HASH(_class, DISABLE); \
+ \
+ _NOTE(CONSTANTCONDITION) \
+ } while (B_FALSE)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_class' - possible side-effects?
#224: FILE: drivers/net/sfc/base/efx_rx.c:312:
+#define LIST_FLAGS(_entryp, _class, _l4_hashing) \
+ do { \
+ if (_l4_hashing) \
+ *(_entryp++) = EFX_RX_HASH(_class, 4TUPLE); \
+ \
+ *(_entryp++) = EFX_RX_HASH(_class, 2TUPLE); \
+ *(_entryp++) = EFX_RX_HASH(_class, DISABLE); \
+ \
+ _NOTE(CONSTANTCONDITION) \
+ } while (B_FALSE)
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#253: FILE: drivers/net/sfc/base/efx_rx.c:341:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#261: FILE: drivers/net/sfc/base/efx_rx.c:349:
+ return (rc);
total: 2 errors, 0 warnings, 3 checks, 320 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2018-04-19 16:42 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1524156112-28615-3-git-send-email-arybchenko@solarflare.com>
2018-04-19 16:42 ` [dpdk-test-report] |WARNING| pw38567 [PATCH v2 2/8] net/sfc/base: add a new means to control RSS hash checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).