From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Ophir Munk <ophirmu@mellanox.com>
Subject: [dpdk-test-report] |WARNING| pw38690 [PATCH] net/tap: remove queue specific offload support
Date: Mon, 23 Apr 2018 13:34:39 +0200 (CEST) [thread overview]
Message-ID: <20180423113439.169A41DBA@dpdk.org> (raw)
In-Reply-To: <HE1PR0501MB2314CE974124127DC0F54978D1890@HE1PR0501MB2314.eurprd05.prod.outlook.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/38690
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#18:
The exact same setup works without your patch (done before sending my first email).
ERROR:DIFF_IN_COMMIT_MSG: Avoid using diff content in the commit message - patch(1) might not work
#260:
--- a/drivers/net/tap/rte_eth_tap.c
ERROR:DOS_LINE_ENDINGS: DOS line endings
#267: FILE: drivers/net/tap/rte_eth_tap.c:1111:
+ if (tx_conf != NULL &&^M$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#267: FILE: drivers/net/tap/rte_eth_tap.c:1111:
+ if (tx_conf != NULL &&^M$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#267: FILE: drivers/net/tap/rte_eth_tap.c:1111:
+ if (tx_conf != NULL &&
[...]
+ txq->csum = !!(tx_conf->offloads &
ERROR:DOS_LINE_ENDINGS: DOS line endings
#268: FILE: drivers/net/tap/rte_eth_tap.c:1112:
+ !!(tx_conf->txq_flags & ETH_TXQ_FLAGS_IGNORE)) {^M$
ERROR:CODE_INDENT: code indent should use tabs where possible
#268: FILE: drivers/net/tap/rte_eth_tap.c:1112:
+ !!(tx_conf->txq_flags & ETH_TXQ_FLAGS_IGNORE)) {^M$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#268: FILE: drivers/net/tap/rte_eth_tap.c:1112:
+ !!(tx_conf->txq_flags & ETH_TXQ_FLAGS_IGNORE)) {^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#269: FILE: drivers/net/tap/rte_eth_tap.c:1113:
+ txq->csum = !!(tx_conf->offloads &^M$
ERROR:CODE_INDENT: code indent should use tabs where possible
#269: FILE: drivers/net/tap/rte_eth_tap.c:1113:
+ txq->csum = !!(tx_conf->offloads &^M$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#269: FILE: drivers/net/tap/rte_eth_tap.c:1113:
+ txq->csum = !!(tx_conf->offloads &^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#270: FILE: drivers/net/tap/rte_eth_tap.c:1114:
+ (DEV_TX_OFFLOAD_IPV4_CKSUM |^M$
ERROR:CODE_INDENT: code indent should use tabs where possible
#270: FILE: drivers/net/tap/rte_eth_tap.c:1114:
+ (DEV_TX_OFFLOAD_IPV4_CKSUM |^M$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#270: FILE: drivers/net/tap/rte_eth_tap.c:1114:
+ (DEV_TX_OFFLOAD_IPV4_CKSUM |^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#271: FILE: drivers/net/tap/rte_eth_tap.c:1115:
+ DEV_TX_OFFLOAD_UDP_CKSUM |^M$
ERROR:CODE_INDENT: code indent should use tabs where possible
#271: FILE: drivers/net/tap/rte_eth_tap.c:1115:
+ DEV_TX_OFFLOAD_UDP_CKSUM |^M$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#271: FILE: drivers/net/tap/rte_eth_tap.c:1115:
+ DEV_TX_OFFLOAD_UDP_CKSUM |^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#272: FILE: drivers/net/tap/rte_eth_tap.c:1116:
+ DEV_TX_OFFLOAD_TCP_CKSUM));^M$
ERROR:CODE_INDENT: code indent should use tabs where possible
#272: FILE: drivers/net/tap/rte_eth_tap.c:1116:
+ DEV_TX_OFFLOAD_TCP_CKSUM));^M$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#272: FILE: drivers/net/tap/rte_eth_tap.c:1116:
+ DEV_TX_OFFLOAD_TCP_CKSUM));^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#273: FILE: drivers/net/tap/rte_eth_tap.c:1117:
+ }^M$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#273: FILE: drivers/net/tap/rte_eth_tap.c:1117:
+ }^M$
ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 14 errors, 9 warnings, 0 checks, 14 lines checked
parent reply other threads:[~2018-04-23 11:34 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <HE1PR0501MB2314CE974124127DC0F54978D1890@HE1PR0501MB2314.eurprd05.prod.outlook.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180423113439.169A41DBA@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=ophirmu@mellanox.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).