* [dpdk-test-report] |WARNING| pw38690 [PATCH] net/tap: remove queue specific offload support
[not found] <HE1PR0501MB2314CE974124127DC0F54978D1890@HE1PR0501MB2314.eurprd05.prod.outlook.com>
@ 2018-04-23 11:34 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2018-04-23 11:34 UTC (permalink / raw)
To: test-report; +Cc: Ophir Munk
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/38690
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#18:
The exact same setup works without your patch (done before sending my first email).
ERROR:DIFF_IN_COMMIT_MSG: Avoid using diff content in the commit message - patch(1) might not work
#260:
--- a/drivers/net/tap/rte_eth_tap.c
ERROR:DOS_LINE_ENDINGS: DOS line endings
#267: FILE: drivers/net/tap/rte_eth_tap.c:1111:
+ if (tx_conf != NULL &&^M$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#267: FILE: drivers/net/tap/rte_eth_tap.c:1111:
+ if (tx_conf != NULL &&^M$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#267: FILE: drivers/net/tap/rte_eth_tap.c:1111:
+ if (tx_conf != NULL &&
[...]
+ txq->csum = !!(tx_conf->offloads &
ERROR:DOS_LINE_ENDINGS: DOS line endings
#268: FILE: drivers/net/tap/rte_eth_tap.c:1112:
+ !!(tx_conf->txq_flags & ETH_TXQ_FLAGS_IGNORE)) {^M$
ERROR:CODE_INDENT: code indent should use tabs where possible
#268: FILE: drivers/net/tap/rte_eth_tap.c:1112:
+ !!(tx_conf->txq_flags & ETH_TXQ_FLAGS_IGNORE)) {^M$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#268: FILE: drivers/net/tap/rte_eth_tap.c:1112:
+ !!(tx_conf->txq_flags & ETH_TXQ_FLAGS_IGNORE)) {^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#269: FILE: drivers/net/tap/rte_eth_tap.c:1113:
+ txq->csum = !!(tx_conf->offloads &^M$
ERROR:CODE_INDENT: code indent should use tabs where possible
#269: FILE: drivers/net/tap/rte_eth_tap.c:1113:
+ txq->csum = !!(tx_conf->offloads &^M$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#269: FILE: drivers/net/tap/rte_eth_tap.c:1113:
+ txq->csum = !!(tx_conf->offloads &^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#270: FILE: drivers/net/tap/rte_eth_tap.c:1114:
+ (DEV_TX_OFFLOAD_IPV4_CKSUM |^M$
ERROR:CODE_INDENT: code indent should use tabs where possible
#270: FILE: drivers/net/tap/rte_eth_tap.c:1114:
+ (DEV_TX_OFFLOAD_IPV4_CKSUM |^M$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#270: FILE: drivers/net/tap/rte_eth_tap.c:1114:
+ (DEV_TX_OFFLOAD_IPV4_CKSUM |^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#271: FILE: drivers/net/tap/rte_eth_tap.c:1115:
+ DEV_TX_OFFLOAD_UDP_CKSUM |^M$
ERROR:CODE_INDENT: code indent should use tabs where possible
#271: FILE: drivers/net/tap/rte_eth_tap.c:1115:
+ DEV_TX_OFFLOAD_UDP_CKSUM |^M$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#271: FILE: drivers/net/tap/rte_eth_tap.c:1115:
+ DEV_TX_OFFLOAD_UDP_CKSUM |^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#272: FILE: drivers/net/tap/rte_eth_tap.c:1116:
+ DEV_TX_OFFLOAD_TCP_CKSUM));^M$
ERROR:CODE_INDENT: code indent should use tabs where possible
#272: FILE: drivers/net/tap/rte_eth_tap.c:1116:
+ DEV_TX_OFFLOAD_TCP_CKSUM));^M$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#272: FILE: drivers/net/tap/rte_eth_tap.c:1116:
+ DEV_TX_OFFLOAD_TCP_CKSUM));^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#273: FILE: drivers/net/tap/rte_eth_tap.c:1117:
+ }^M$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#273: FILE: drivers/net/tap/rte_eth_tap.c:1117:
+ }^M$
ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 14 errors, 9 warnings, 0 checks, 14 lines checked
^ permalink raw reply [flat|nested] only message in thread