From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [dpdk-test-report] |WARNING| pw38956 [PATCH next 10/10] net/bond: convert to dynamic logging
Date: Wed, 25 Apr 2018 17:58:23 +0200 (CEST) [thread overview]
Message-ID: <20180425155823.B7A478E84@dpdk.org> (raw)
In-Reply-To: <20180425155646.3627-11-stephen@networkplumber.org>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/38956
_coding style issues_
WARNING:MISSING_SPACE: break quoted strings at a space character
#138: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:211:
+ "Receive and transmit functions must be invoked on bonded"
+ "interface at least 10 times per second or LACP will notwork correctly",
WARNING:MISSING_SPACE: break quoted strings at a space character
#151: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:219:
+ "Receive and transmit functions must be invoked on bonded"
+ "interface at least 10 times per second or LACP will not work correctly",
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eth_h' - possible side-effects?
#289: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:574:
+#define MODE6_DEBUG(info, src_ip, dst_ip, eth_h, arp_op, port, burstnumber) \
+ rte_log(RTE_LOG_DEBUG, logtype_bond, \
+ "%s port:%d SrcMAC:%02X:%02X:%02X:%02X:%02X:%02X SrcIP:%s " \
+ "DstMAC:%02X:%02X:%02X:%02X:%02X:%02X DstIP:%s %s %d
", \
+ info, \
+ port, \
+ eth_h->s_addr.addr_bytes[0], eth_h->s_addr.addr_bytes[1], \
+ eth_h->s_addr.addr_bytes[2], eth_h->s_addr.addr_bytes[3], \
+ eth_h->s_addr.addr_bytes[4], eth_h->s_addr.addr_bytes[5], \
+ src_ip, \
+ eth_h->d_addr.addr_bytes[0], eth_h->d_addr.addr_bytes[1], \
+ eth_h->d_addr.addr_bytes[2], eth_h->d_addr.addr_bytes[3], \
+ eth_h->d_addr.addr_bytes[4], eth_h->d_addr.addr_bytes[5], \
+ dst_ip, \
+ arp_op, ++burstnumber)
WARNING:LONG_LINE: line over 90 characters
#364: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1926:
+ slave_eth_dev->data->port_id, errval);
WARNING:LONG_LINE: line over 90 characters
#529: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:3213:
+ &bond_ethdev_parse_bond_mac_addr_kvarg, &bond_mac) < 0) {
WARNING:LONG_LINE: line over 90 characters
#564: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:3239:
+ &bond_ethdev_parse_balance_xmit_policy_kvarg, &xmit_policy) !=
WARNING:LONG_LINE: line over 90 characters
#623: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:3283:
+ &bond_ethdev_parse_slave_port_kvarg, &slave_ports) != 0) {
total: 0 errors, 6 warnings, 1 checks, 762 lines checked
parent reply other threads:[~2018-04-25 15:58 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20180425155646.3627-11-stephen@networkplumber.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180425155823.B7A478E84@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).