From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id B7A478E84; Wed, 25 Apr 2018 17:58:23 +0200 (CEST)
In-Reply-To: <20180425155646.3627-11-stephen@networkplumber.org>
References: <20180425155646.3627-11-stephen@networkplumber.org>
To: test-report@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Message-Id: <20180425155823.B7A478E84@dpdk.org>
Date: Wed, 25 Apr 2018 17:58:23 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw38956 [PATCH next 10/10] net/bond:
	convert to dynamic logging
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Apr 2018 15:58:24 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/38956

_coding style issues_


WARNING:MISSING_SPACE: break quoted strings at a space character
#138: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:211:
+			     "Receive and transmit functions must be invoked on bonded"
+			     "interface at least 10 times per second or LACP will notwork correctly",

WARNING:MISSING_SPACE: break quoted strings at a space character
#151: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:219:
+			     "Receive and transmit functions must be invoked on bonded"
+			     "interface at least 10 times per second or LACP will not work correctly",

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eth_h' - possible side-effects?
#289: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:574:
+#define MODE6_DEBUG(info, src_ip, dst_ip, eth_h, arp_op, port, burstnumber) \
+	rte_log(RTE_LOG_DEBUG, logtype_bond,				\
+		"%s port:%d SrcMAC:%02X:%02X:%02X:%02X:%02X:%02X SrcIP:%s " \
+		"DstMAC:%02X:%02X:%02X:%02X:%02X:%02X DstIP:%s %s %d
", \
+		info,							\
+		port,							\
+		eth_h->s_addr.addr_bytes[0], eth_h->s_addr.addr_bytes[1], \
+		eth_h->s_addr.addr_bytes[2], eth_h->s_addr.addr_bytes[3], \
+		eth_h->s_addr.addr_bytes[4], eth_h->s_addr.addr_bytes[5], \
+		src_ip,							\
+		eth_h->d_addr.addr_bytes[0], eth_h->d_addr.addr_bytes[1], \
+		eth_h->d_addr.addr_bytes[2], eth_h->d_addr.addr_bytes[3], \
+		eth_h->d_addr.addr_bytes[4], eth_h->d_addr.addr_bytes[5], \
+		dst_ip,							\
+		arp_op, ++burstnumber)

WARNING:LONG_LINE: line over 90 characters
#364: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1926:
+						     slave_eth_dev->data->port_id, errval);

WARNING:LONG_LINE: line over 90 characters
#529: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:3213:
+				       &bond_ethdev_parse_bond_mac_addr_kvarg, &bond_mac) < 0) {

WARNING:LONG_LINE: line over 90 characters
#564: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:3239:
+				       &bond_ethdev_parse_balance_xmit_policy_kvarg, &xmit_policy) !=

WARNING:LONG_LINE: line over 90 characters
#623: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:3283:
+				       &bond_ethdev_parse_slave_port_kvarg, &slave_ports) != 0) {

total: 0 errors, 6 warnings, 1 checks, 762 lines checked