* [dpdk-test-report] |WARNING| pw38956 [PATCH next 10/10] net/bond: convert to dynamic logging
[not found] <20180425155646.3627-11-stephen@networkplumber.org>
@ 2018-04-25 15:58 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2018-04-25 15:58 UTC (permalink / raw)
To: test-report; +Cc: Stephen Hemminger
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/38956
_coding style issues_
WARNING:MISSING_SPACE: break quoted strings at a space character
#138: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:211:
+ "Receive and transmit functions must be invoked on bonded"
+ "interface at least 10 times per second or LACP will notwork correctly",
WARNING:MISSING_SPACE: break quoted strings at a space character
#151: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:219:
+ "Receive and transmit functions must be invoked on bonded"
+ "interface at least 10 times per second or LACP will not work correctly",
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eth_h' - possible side-effects?
#289: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:574:
+#define MODE6_DEBUG(info, src_ip, dst_ip, eth_h, arp_op, port, burstnumber) \
+ rte_log(RTE_LOG_DEBUG, logtype_bond, \
+ "%s port:%d SrcMAC:%02X:%02X:%02X:%02X:%02X:%02X SrcIP:%s " \
+ "DstMAC:%02X:%02X:%02X:%02X:%02X:%02X DstIP:%s %s %d
", \
+ info, \
+ port, \
+ eth_h->s_addr.addr_bytes[0], eth_h->s_addr.addr_bytes[1], \
+ eth_h->s_addr.addr_bytes[2], eth_h->s_addr.addr_bytes[3], \
+ eth_h->s_addr.addr_bytes[4], eth_h->s_addr.addr_bytes[5], \
+ src_ip, \
+ eth_h->d_addr.addr_bytes[0], eth_h->d_addr.addr_bytes[1], \
+ eth_h->d_addr.addr_bytes[2], eth_h->d_addr.addr_bytes[3], \
+ eth_h->d_addr.addr_bytes[4], eth_h->d_addr.addr_bytes[5], \
+ dst_ip, \
+ arp_op, ++burstnumber)
WARNING:LONG_LINE: line over 90 characters
#364: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1926:
+ slave_eth_dev->data->port_id, errval);
WARNING:LONG_LINE: line over 90 characters
#529: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:3213:
+ &bond_ethdev_parse_bond_mac_addr_kvarg, &bond_mac) < 0) {
WARNING:LONG_LINE: line over 90 characters
#564: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:3239:
+ &bond_ethdev_parse_balance_xmit_policy_kvarg, &xmit_policy) !=
WARNING:LONG_LINE: line over 90 characters
#623: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:3283:
+ &bond_ethdev_parse_slave_port_kvarg, &slave_ports) != 0) {
total: 0 errors, 6 warnings, 1 checks, 762 lines checked
^ permalink raw reply [flat|nested] only message in thread