From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw38967 [PATCH v3 1/8] net/sfc/base: cope with clang warning on negative shift
Date: Wed, 25 Apr 2018 19:52:05 +0200 (CEST) [thread overview]
Message-ID: <20180425175205.5407BAA99@dpdk.org> (raw)
In-Reply-To: <1524678704-29354-2-git-send-email-arybchenko@solarflare.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/38967
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_val' - possible side-effects?
#43: FILE: drivers/net/sfc/base/efx_types.h:338:
+#define EFX_SSUB(_val, _sub) \
+ ((_val) > (_sub) ? ((_val) - (_sub)) : 0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_sub' - possible side-effects?
#43: FILE: drivers/net/sfc/base/efx_types.h:338:
+#define EFX_SSUB(_val, _sub) \
+ ((_val) > (_sub) ? ((_val) - (_sub)) : 0)
ERROR:SPACING: space required after that ',' (ctx:VxV)
#109: FILE: drivers/net/sfc/base/efx_types.h:1306:
+ ((uint32_t)1 << EFX_SSUB((_bit),(_base))) : \
^
total: 1 errors, 0 warnings, 2 checks, 89 lines checked
parent reply other threads:[~2018-04-25 17:52 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1524678704-29354-2-git-send-email-arybchenko@solarflare.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180425175205.5407BAA99@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=arybchenko@solarflare.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).