From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 5407BAA99; Wed, 25 Apr 2018 19:52:05 +0200 (CEST)
In-Reply-To: <1524678704-29354-2-git-send-email-arybchenko@solarflare.com>
References: <1524678704-29354-2-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20180425175205.5407BAA99@dpdk.org>
Date: Wed, 25 Apr 2018 19:52:05 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw38967 [PATCH v3 1/8] net/sfc/base:
	cope with clang warning on negative shift
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Apr 2018 17:52:05 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/38967

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse '_val' - possible side-effects?
#43: FILE: drivers/net/sfc/base/efx_types.h:338:
+#define	EFX_SSUB(_val, _sub) \
+	((_val) > (_sub) ? ((_val) - (_sub)) : 0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_sub' - possible side-effects?
#43: FILE: drivers/net/sfc/base/efx_types.h:338:
+#define	EFX_SSUB(_val, _sub) \
+	((_val) > (_sub) ? ((_val) - (_sub)) : 0)

ERROR:SPACING: space required after that ',' (ctx:VxV)
#109: FILE: drivers/net/sfc/base/efx_types.h:1306:
+		((uint32_t)1 << EFX_SSUB((_bit),(_base))) :		\
 		                               ^

total: 1 errors, 0 warnings, 2 checks, 89 lines checked