From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 68473A48F; Wed, 25 Apr 2018 19:53:47 +0200 (CEST)
In-Reply-To: <1524678704-29354-3-git-send-email-arybchenko@solarflare.com>
References: <1524678704-29354-3-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20180425175347.68473A48F@dpdk.org>
Date: Wed, 25 Apr 2018 19:53:47 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw38969 [PATCH v3 2/8] net/sfc/base:
	add a new means to control RSS hash
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Apr 2018 17:53:47 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/38969

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#199: FILE: drivers/net/sfc/base/efx.h:2178:
+extern	__checkReturn				efx_rc_t

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_entryp' - possible side-effects?
#232: FILE: drivers/net/sfc/base/efx_rx.c:312:
+#define	LIST_FLAGS(_entryp, _class, _l4_hashing)			\
+	do {								\
+		if (_l4_hashing)					\
+			*(_entryp++) = EFX_RX_HASH(_class, 4TUPLE);	\
+									\
+		*(_entryp++) = EFX_RX_HASH(_class, 2TUPLE);		\
+		*(_entryp++) = EFX_RX_HASH(_class, DISABLE);		\
+									\
+		_NOTE(CONSTANTCONDITION)				\
+	} while (B_FALSE)

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_class' - possible side-effects?
#232: FILE: drivers/net/sfc/base/efx_rx.c:312:
+#define	LIST_FLAGS(_entryp, _class, _l4_hashing)			\
+	do {								\
+		if (_l4_hashing)					\
+			*(_entryp++) = EFX_RX_HASH(_class, 4TUPLE);	\
+									\
+		*(_entryp++) = EFX_RX_HASH(_class, 2TUPLE);		\
+		*(_entryp++) = EFX_RX_HASH(_class, DISABLE);		\
+									\
+		_NOTE(CONSTANTCONDITION)				\
+	} while (B_FALSE)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#261: FILE: drivers/net/sfc/base/efx_rx.c:341:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#269: FILE: drivers/net/sfc/base/efx_rx.c:349:
+	return (rc);

total: 2 errors, 0 warnings, 3 checks, 331 lines checked