From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id B77A18D9F; Fri, 27 Apr 2018 00:05:18 +0200 (CEST)
In-Reply-To: <1524780214-23196-4-git-send-email-medvedkinv@gmail.com>
References: <1524780214-23196-4-git-send-email-medvedkinv@gmail.com>
To: test-report@dpdk.org
Cc: Vladimir Medvedkin <medvedkinv@gmail.com>
Message-Id: <20180426220518.B77A18D9F@dpdk.org>
Date: Fri, 27 Apr 2018 00:05:18 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw39063 [PATCH v4 3/4] Add autotests
	for RIB library
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Apr 2018 22:05:19 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/39063

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#102: FILE: test/test/test_rib.c:17:
+#define TEST_RIB_ASSERT(cond) do {				\
+	if (!(cond)) {						\
+		printf("Error at line %d:
", __LINE__);	\
+		return -1;					\
+	}							\
+} while (0)

WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(tests)
#128: FILE: test/test/test_rib.c:43:
+#define NUM_RIB_TESTS (sizeof(tests)/sizeof(tests[0]))

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#767: FILE: test/test/test_rib_lpm_comp.c:21:
+#define TEST_RIB_ASSERT(cond) do {				\
+	if (!(cond)) {						\
+		printf("Error at line %d:
", __LINE__);	\
+		return -1;					\
+	}							\
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#962: FILE: test/test/test_rib_perf.c:21:
+#define TEST_RIB_ASSERT(cond) do {				\
+	if (!(cond)) {						\
+		printf("Error at line %d:
", __LINE__);	\
+		return -1;					\
+	}							\
+} while (0)

total: 0 errors, 4 warnings, 1014 lines checked