From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Thomas Monjalon <thomas@monjalon.net>
Subject: [dpdk-test-report] |WARNING| pw39142 [PATCH v2 2/3] bus/fslmc: optimize physical to virtual address searching
Date: Fri, 27 Apr 2018 21:25:20 +0200 (CEST) [thread overview]
Message-ID: <20180427192520.A6BAFA48A@dpdk.org> (raw)
In-Reply-To: <2860578.1zL41RiOr7@xps>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/39142
_coding style issues_
ERROR:DIFF_IN_COMMIT_MSG: Avoid using diff content in the commit message - patch(1) might not work
#49:
--- a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#65: FILE: drivers/bus/fslmc/portal/dpaa2_hw_pvt.h:282:
+ TAILQ_FOREACH(ms, &rte_dpaa2_memsegs, next) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (15, 23)
#66: FILE: drivers/bus/fslmc/portal/dpaa2_hw_pvt.h:283:
if (paddr >= ms->iova && paddr <
[...]
+ return RTE_PTR_ADD(ms->vaddr, (uintptr_t)(paddr - ms->iova));
ERROR:CODE_INDENT: code indent should use tabs where possible
#69: FILE: drivers/bus/fslmc/portal/dpaa2_hw_pvt.h:285:
+ return RTE_PTR_ADD(ms->vaddr, (uintptr_t)(paddr - ms->iova));$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#69: FILE: drivers/bus/fslmc/portal/dpaa2_hw_pvt.h:285:
+ return RTE_PTR_ADD(ms->vaddr, (uintptr_t)(paddr - ms->iova));$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#96: FILE: drivers/mempool/dpaa2/dpaa2_hw_mempool.c:40:
+ = TAILQ_HEAD_INITIALIZER(rte_dpaa2_memsegs);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#105: FILE: drivers/mempool/dpaa2/dpaa2_hw_mempool.c:397:
+ TAILQ_INSERT_HEAD(&rte_dpaa2_memsegs, ms, next);$
ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 3 errors, 5 warnings, 54 lines checked
parent reply other threads:[~2018-04-27 19:25 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <2860578.1zL41RiOr7@xps>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180427192520.A6BAFA48A@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).