From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Yongseok Koh <yskoh@mellanox.com>
Subject: [dpdk-test-report] |WARNING| pw39427 [PATCH v2 2/2] net/mlx5: free eth dev port in case of error
Date: Mon, 7 May 2018 19:57:14 +0200 (CEST) [thread overview]
Message-ID: <20180507175714.234FB3230@dpdk.org> (raw)
In-Reply-To: <20180507175534.GA42287@yongseok-MBP.local>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/39427
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#38:
> @@ -1063,6 +1063,8 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
ERROR:CORRUPTED_PATCH: patch seems to be corrupt (line wrapped?)
#65: FILE: lib/librte_ethdev/rte_ethdev.c:352:
eth_dev->state = RTE_ETH_DEV_UNUSED;
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#68: FILE: lib/librte_ethdev/rte_ethdev.c:354:
+ if (rte_eal_process_type() == RTE_PROC_PRIMARY)$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#68: FILE: lib/librte_ethdev/rte_ethdev.c:354:
+ if (rte_eal_process_type() == RTE_PROC_PRIMARY)
+ memset(eth_dev->data, 0, sizeof(struct rte_eth_dev_data));
ERROR:CODE_INDENT: code indent should use tabs where possible
#69: FILE: lib/librte_ethdev/rte_ethdev.c:355:
+ memset(eth_dev->data, 0, sizeof(struct rte_eth_dev_data));$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#69: FILE: lib/librte_ethdev/rte_ethdev.c:355:
+ memset(eth_dev->data, 0, sizeof(struct rte_eth_dev_data));$
ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 3 errors, 4 warnings, 9 lines checked
parent reply other threads:[~2018-05-07 17:57 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20180507175534.GA42287@yongseok-MBP.local>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180507175714.234FB3230@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).