From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 234FB3230; Mon,  7 May 2018 19:57:14 +0200 (CEST)
In-Reply-To: <20180507175534.GA42287@yongseok-MBP.local>
References: <20180507175534.GA42287@yongseok-MBP.local>
To: test-report@dpdk.org
Cc: Yongseok Koh <yskoh@mellanox.com>
Message-Id: <20180507175714.234FB3230@dpdk.org>
Date: Mon,  7 May 2018 19:57:14 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw39427 [PATCH v2 2/2] net/mlx5: free
	eth dev port in case of error
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 07 May 2018 17:57:14 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/39427

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#38: 
> @@ -1063,6 +1063,8 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,

ERROR:CORRUPTED_PATCH: patch seems to be corrupt (line wrapped?)
#65: FILE: lib/librte_ethdev/rte_ethdev.c:352:
	eth_dev->state = RTE_ETH_DEV_UNUSED;

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#68: FILE: lib/librte_ethdev/rte_ethdev.c:354:
+       if (rte_eal_process_type() == RTE_PROC_PRIMARY)$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#68: FILE: lib/librte_ethdev/rte_ethdev.c:354:
+       if (rte_eal_process_type() == RTE_PROC_PRIMARY)
+               memset(eth_dev->data, 0, sizeof(struct rte_eth_dev_data));

ERROR:CODE_INDENT: code indent should use tabs where possible
#69: FILE: lib/librte_ethdev/rte_ethdev.c:355:
+               memset(eth_dev->data, 0, sizeof(struct rte_eth_dev_data));$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#69: FILE: lib/librte_ethdev/rte_ethdev.c:355:
+               memset(eth_dev->data, 0, sizeof(struct rte_eth_dev_data));$

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 3 errors, 4 warnings, 9 lines checked