From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 506751CE67; Sun, 13 May 2018 15:32:09 +0200 (CEST) In-Reply-To: References: To: test-report@dpdk.org Cc: Shahaf Shuler Message-Id: <20180513133209.506751CE67@dpdk.org> Date: Sun, 13 May 2018 15:32:09 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw39929 [PATCH 2/3] ethdev: fail if Tx queue offload is not supported at all X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 May 2018 13:32:09 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/39929 _coding style issues_ WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #18: > Subject: Re: [dpdk-dev] [PATCH 2/3] ethdev: fail if Tx queue offload is not WARNING:LEADING_SPACE: please, no spaces at the start of a line #104: FILE: lib/librte_ethdev/rte_ethdev.c:1730: + if (tx_conf->txq_flags & ETH_TXQ_FLAGS_IGNORE) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15) #104: FILE: lib/librte_ethdev/rte_ethdev.c:1730: + if (tx_conf->txq_flags & ETH_TXQ_FLAGS_IGNORE) { [...] + if ((local_conf.offloads & dev_info.tx_queue_offload_capa) != ERROR:CODE_INDENT: code indent should use tabs where possible #105: FILE: lib/librte_ethdev/rte_ethdev.c:1731: + /*$ ERROR:CODE_INDENT: code indent should use tabs where possible #106: FILE: lib/librte_ethdev/rte_ethdev.c:1732: + * New added offloadings for this queue are those not enabled in$ ERROR:CODE_INDENT: code indent should use tabs where possible #107: FILE: lib/librte_ethdev/rte_ethdev.c:1733: + * rte_eth_dev_configure( ) and they must be per-queue type.$ ERROR:CODE_INDENT: code indent should use tabs where possible #108: FILE: lib/librte_ethdev/rte_ethdev.c:1734: + * A pure per-port offloading can't be enabled on a queue while$ ERROR:CODE_INDENT: code indent should use tabs where possible #109: FILE: lib/librte_ethdev/rte_ethdev.c:1735: + * disabled on another queue. A pure per-port offloading can't$ ERROR:CODE_INDENT: code indent should use tabs where possible #110: FILE: lib/librte_ethdev/rte_ethdev.c:1736: + * be enabled for any queue as new added one if it hasn't been$ ERROR:CODE_INDENT: code indent should use tabs where possible #111: FILE: lib/librte_ethdev/rte_ethdev.c:1737: + * enabled in rte_eth_dev_configure( ).$ ERROR:CODE_INDENT: code indent should use tabs where possible #112: FILE: lib/librte_ethdev/rte_ethdev.c:1738: + */$ ERROR:CODE_INDENT: code indent should use tabs where possible #113: FILE: lib/librte_ethdev/rte_ethdev.c:1739: + if ((local_conf.offloads & dev_info.tx_queue_offload_capa) !=$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #113: FILE: lib/librte_ethdev/rte_ethdev.c:1739: + if ((local_conf.offloads & dev_info.tx_queue_offload_capa) !=$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (15, 23) #113: FILE: lib/librte_ethdev/rte_ethdev.c:1739: + if ((local_conf.offloads & dev_info.tx_queue_offload_capa) != [...] + ethdev_log(ERR, "Ethdev port_id=%d tx_queue_id=%d, new " ERROR:CODE_INDENT: code indent should use tabs where possible #114: FILE: lib/librte_ethdev/rte_ethdev.c:1740: + local_conf.offloads) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #114: FILE: lib/librte_ethdev/rte_ethdev.c:1740: + local_conf.offloads) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #115: FILE: lib/librte_ethdev/rte_ethdev.c:1741: + ethdev_log(ERR, "Ethdev port_id=%d tx_queue_id=%d, new "$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #115: FILE: lib/librte_ethdev/rte_ethdev.c:1741: + ethdev_log(ERR, "Ethdev port_id=%d tx_queue_id=%d, new "$ ERROR:CODE_INDENT: code indent should use tabs where possible #116: FILE: lib/librte_ethdev/rte_ethdev.c:1742: + "added offloads 0x%" PRIx64 " must be "$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #116: FILE: lib/librte_ethdev/rte_ethdev.c:1742: + "added offloads 0x%" PRIx64 " must be "$ ERROR:CODE_INDENT: code indent should use tabs where possible #117: FILE: lib/librte_ethdev/rte_ethdev.c:1743: + "within pre-queue offload capabilities "$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #117: FILE: lib/librte_ethdev/rte_ethdev.c:1743: + "within pre-queue offload capabilities "$ ERROR:CODE_INDENT: code indent should use tabs where possible #118: FILE: lib/librte_ethdev/rte_ethdev.c:1744: + " 0x%" PRIx64 " in %s( ) ",$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #118: FILE: lib/librte_ethdev/rte_ethdev.c:1744: + " 0x%" PRIx64 " in %s( ) ",$ ERROR:CODE_INDENT: code indent should use tabs where possible #119: FILE: lib/librte_ethdev/rte_ethdev.c:1745: + port_id,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #119: FILE: lib/librte_ethdev/rte_ethdev.c:1745: + port_id,$ ERROR:CODE_INDENT: code indent should use tabs where possible #120: FILE: lib/librte_ethdev/rte_ethdev.c:1746: + tx_queue_id,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #120: FILE: lib/librte_ethdev/rte_ethdev.c:1746: + tx_queue_id,$ ERROR:CODE_INDENT: code indent should use tabs where possible #121: FILE: lib/librte_ethdev/rte_ethdev.c:1747: + local_conf.offloads,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #121: FILE: lib/librte_ethdev/rte_ethdev.c:1747: + local_conf.offloads,$ ERROR:CODE_INDENT: code indent should use tabs where possible #122: FILE: lib/librte_ethdev/rte_ethdev.c:1748: + dev_info.tx_queue_offload_capa,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #122: FILE: lib/librte_ethdev/rte_ethdev.c:1748: + dev_info.tx_queue_offload_capa,$ ERROR:CODE_INDENT: code indent should use tabs where possible #123: FILE: lib/librte_ethdev/rte_ethdev.c:1749: + __func__);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #123: FILE: lib/librte_ethdev/rte_ethdev.c:1749: + __func__);$ ERROR:CODE_INDENT: code indent should use tabs where possible #124: FILE: lib/librte_ethdev/rte_ethdev.c:1750: + return -EINVAL;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #124: FILE: lib/librte_ethdev/rte_ethdev.c:1750: + return -EINVAL;$ ERROR:CODE_INDENT: code indent should use tabs where possible #125: FILE: lib/librte_ethdev/rte_ethdev.c:1751: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #125: FILE: lib/librte_ethdev/rte_ethdev.c:1751: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #126: FILE: lib/librte_ethdev/rte_ethdev.c:1752: + } else {$ ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s) total: 22 errors, 18 warnings, 51 lines checked