From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: "Александр Киселев" <kiselev99@gmail.com>
Subject: [dpdk-test-report] |WARNING| pw40008 [PATCH] librte_ip_frag: mbuf count expiration
Date: Mon, 14 May 2018 16:23:59 +0200 (CEST) [thread overview]
Message-ID: <20180514142359.7542E1C8AF@dpdk.org> (raw)
In-Reply-To: <2310632874.20180514172345@gmail.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/40008
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#21:
There might be situations (kind of attack when a lot of fragmented packets are sent
ERROR:TRAILING_WHITESPACE: trailing whitespace
#65: FILE: lib/librte_ip_frag/ip_frag_common.h:64:
+struct rte_mbuf * ip_frag_process(struct rte_ip_frag_tbl *tbl, $
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#65: FILE: lib/librte_ip_frag/ip_frag_common.h:64:
+struct rte_mbuf * ip_frag_process(struct rte_ip_frag_tbl *tbl,
ERROR:TRAILING_WHITESPACE: trailing whitespace
#66: FILE: lib/librte_ip_frag/ip_frag_common.h:65:
+ struct ip_frag_pkt *fp, struct rte_ip_frag_death_row *dr, $
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#66: FILE: lib/librte_ip_frag/ip_frag_common.h:65:
+ struct ip_frag_pkt *fp, struct rte_ip_frag_death_row *dr, $
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#67: FILE: lib/librte_ip_frag/ip_frag_common.h:66:
+ struct rte_mbuf *mb, uint16_t ofs, uint16_t len, uint16_t more_frags);$
ERROR:TRAILING_WHITESPACE: trailing whitespace
#85: FILE: lib/librte_ip_frag/ip_frag_common.h:121:
+ip_frag_free(struct rte_ip_frag_tbl *tbl, struct ip_frag_pkt *fp, $
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#86: FILE: lib/librte_ip_frag/ip_frag_common.h:122:
+ struct rte_ip_frag_death_row *dr)$
ERROR:CODE_INDENT: code indent should use tabs where possible
#94: FILE: lib/librte_ip_frag/ip_frag_common.h:131:
+ tbl->nb_mbufs --;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#94: FILE: lib/librte_ip_frag/ip_frag_common.h:131:
+ tbl->nb_mbufs --;$
ERROR:SPACING: space prohibited before that '--' (ctx:WxO)
#94: FILE: lib/librte_ip_frag/ip_frag_common.h:131:
+ tbl->nb_mbufs --;
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#105: FILE: lib/librte_ip_frag/ip_frag_common.h:190:
+ struct ip_frag_pkt *fp)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#107: FILE: lib/librte_ip_frag/ip_frag_common.h:192:
+ ip_frag_free(tbl, fp, dr);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#108: FILE: lib/librte_ip_frag/ip_frag_common.h:193:
+ ip_frag_key_invalidate(&fp->key);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#109: FILE: lib/librte_ip_frag/ip_frag_common.h:194:
+ TAILQ_REMOVE(&tbl->lru, fp, lru);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#110: FILE: lib/librte_ip_frag/ip_frag_common.h:195:
+ tbl->use_entries--;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#111: FILE: lib/librte_ip_frag/ip_frag_common.h:196:
+ IP_FRAG_TBL_STAT_UPDATE(&tbl->stat, del_num, 1);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#148: FILE: lib/librte_ip_frag/ip_frag_internal.c:63:
+ ip_frag_free(tbl, fp, dr);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#159: FILE: lib/librte_ip_frag/ip_frag_internal.c:123:
+ struct rte_ip_frag_death_row *dr, struct rte_mbuf *mb, uint16_t ofs,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#160: FILE: lib/librte_ip_frag/ip_frag_internal.c:124:
+ uint16_t len, uint16_t more_frags)$
ERROR:CODE_INDENT: code indent should use tabs where possible
#169: FILE: lib/librte_ip_frag/ip_frag_internal.c:182:
+ ip_frag_free(tbl, fp, dr);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#169: FILE: lib/librte_ip_frag/ip_frag_internal.c:182:
+ ip_frag_free(tbl, fp, dr);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#177: FILE: lib/librte_ip_frag/ip_frag_internal.c:192:
+ tbl->nb_mbufs++;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#186: FILE: lib/librte_ip_frag/ip_frag_internal.c:241:
+ ip_frag_free(tbl, fp, dr);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#186: FILE: lib/librte_ip_frag/ip_frag_internal.c:241:
+ ip_frag_free(tbl, fp, dr);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#187: FILE: lib/librte_ip_frag/ip_frag_internal.c:242:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#188: FILE: lib/librte_ip_frag/ip_frag_internal.c:243:
+ else {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#188: FILE: lib/librte_ip_frag/ip_frag_internal.c:243:
+ else {
+ tbl->nb_mbufs -= fp->last_idx;
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#188: FILE: lib/librte_ip_frag/ip_frag_internal.c:243:
+ }
+ else {
WARNING:BRACES: braces {} are not necessary for single statement blocks
#188: FILE: lib/librte_ip_frag/ip_frag_internal.c:243:
+ else {
+ tbl->nb_mbufs -= fp->last_idx;
}
ERROR:CODE_INDENT: code indent should use tabs where possible
#189: FILE: lib/librte_ip_frag/ip_frag_internal.c:244:
+ tbl->nb_mbufs -= fp->last_idx;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#189: FILE: lib/librte_ip_frag/ip_frag_internal.c:244:
+ tbl->nb_mbufs -= fp->last_idx;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#207: FILE: lib/librte_ip_frag/rte_ip_frag.h:102:
+ struct rte_mbuf *row[IP_FRAG_DEATH_ROW_MBUF_LEN];$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#215: FILE: lib/librte_ip_frag/rte_ip_frag.h:127:
+ uint32_t nb_mbufs; /**< num of mbufs holded in the tbl. */$
ERROR:TRAILING_WHITESPACE: trailing whitespace
#228: FILE: lib/librte_ip_frag/rte_ip_frag.h:365:
+ * $
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#235: FILE: lib/librte_ip_frag/rte_ip_frag.h:372:
+ return tbl->nb_mbufs;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#242: FILE: lib/librte_ip_frag/rte_ip_frag.h:379:
+ struct rte_ip_frag_death_row *dr, uint64_t tms);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#260: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:107:
+ tbl->nb_mbufs = 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#274: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:160:
+ struct rte_ip_frag_death_row *dr, uint64_t tms)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#276: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:162:
+ uint64_t max_cycles;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#277: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:163:
+ struct ip_frag_pkt *fp;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#279: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:165:
+ max_cycles = tbl->max_cycles;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#281: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:167:
+ TAILQ_FOREACH(fp, &tbl->lru, lru)$
ERROR:CODE_INDENT: code indent should use tabs where possible
#282: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:168:
+ if (max_cycles + fp->start < tms) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#282: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:168:
+ if (max_cycles + fp->start < tms) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (15, 23)
#282: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:168:
+ if (max_cycles + fp->start < tms) {
[...]
+ if (IP_FRAG_DEATH_ROW_MBUF_LEN - dr->cnt >= fp->last_idx)
ERROR:CODE_INDENT: code indent should use tabs where possible
#283: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:169:
+ /* check that death row has enough space */$
ERROR:CODE_INDENT: code indent should use tabs where possible
#284: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:170:
+ if (IP_FRAG_DEATH_ROW_MBUF_LEN - dr->cnt >= fp->last_idx)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#284: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:170:
+ if (IP_FRAG_DEATH_ROW_MBUF_LEN - dr->cnt >= fp->last_idx)$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (23, 31)
#284: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:170:
+ if (IP_FRAG_DEATH_ROW_MBUF_LEN - dr->cnt >= fp->last_idx)
+ ip_frag_tbl_del(tbl, dr, fp);
ERROR:CODE_INDENT: code indent should use tabs where possible
#285: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:171:
+ ip_frag_tbl_del(tbl, dr, fp);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#285: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:171:
+ ip_frag_tbl_del(tbl, dr, fp);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#286: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:172:
+ else$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#286: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:172:
+ else$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (23, 31)
#286: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:172:
+ else
+ return;
ERROR:CODE_INDENT: code indent should use tabs where possible
#287: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:173:
+ return;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#287: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:173:
+ return;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#288: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:174:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#288: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:174:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#289: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:175:
+ else {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#289: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:175:
+ else {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (15, 23)
#289: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:175:
+ else {
+ return;
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#289: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:175:
+ }
+ else {
ERROR:CODE_INDENT: code indent should use tabs where possible
#290: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:176:
+ return;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#290: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:176:
+ return;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#291: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:177:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#291: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:177:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#299: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:185:
+ uint32_t i, cnt;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#300: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:186:
+ printf("entries in use: %u, mbuf holded %u
", tbl->use_entries,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#301: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:187:
+ tbl->nb_mbufs);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#301: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:187:
+ tbl->nb_mbufs);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#302: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:188:
+ struct ip_frag_pkt *fp;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#303: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:189:
+ TAILQ_FOREACH(fp, &tbl->lru, lru)$
ERROR:CODE_INDENT: code indent should use tabs where possible
#304: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:190:
+ if (!ip_frag_key_is_empty(&fp->key)) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#304: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:190:
+ if (!ip_frag_key_is_empty(&fp->key)) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (15, 23)
#304: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:190:
+ if (!ip_frag_key_is_empty(&fp->key)) {
[...]
+ cnt = 0;
ERROR:CODE_INDENT: code indent should use tabs where possible
#306: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:192:
+ /* cnt mbufs in the packet */$
ERROR:CODE_INDENT: code indent should use tabs where possible
#307: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:193:
+ cnt = 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#307: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:193:
+ cnt = 0;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#308: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:194:
+ for (i=0; i!=fp->last_idx; i++)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#308: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:194:
+ for (i=0; i!=fp->last_idx; i++)$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (23, 31)
#308: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:194:
+ for (i=0; i!=fp->last_idx; i++)
+ if (fp->frags[i].mb != NULL)
ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#308: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:194:
+ for (i=0; i!=fp->last_idx; i++)
^
ERROR:SPACING: spaces required around that '!=' (ctx:VxV)
#308: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:194:
+ for (i=0; i!=fp->last_idx; i++)
^
ERROR:CODE_INDENT: code indent should use tabs where possible
#309: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:195:
+ if (fp->frags[i].mb != NULL)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#309: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:195:
+ if (fp->frags[i].mb != NULL)$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (31, 39)
#309: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:195:
+ if (fp->frags[i].mb != NULL)
+ cnt++;
ERROR:CODE_INDENT: code indent should use tabs where possible
#310: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:196:
+ cnt++;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#310: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:196:
+ cnt++;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#312: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:198:
+ printf("start %"PRIu64", mbuf cnt %u
", fp->start, cnt);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#312: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:198:
+ printf("start %"PRIu64", mbuf cnt %u
", fp->start, cnt);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#313: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:199:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#313: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:199:
+ }$
WARNING:MISSING_EOF_NEWLINE: adding a line without newline at end of file
#316: FILE: lib/librte_ip_frag/rte_ip_frag_common.c:202:
+#endif /* RTE_IP_FRAG_DEBUG */
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#327: FILE: lib/librte_ip_frag/rte_ipv4_reassembly.c:176:
+ mb = ip_frag_process(tbl, fp, dr, mb, ip_ofs, ip_len, ip_flag);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#340: FILE: lib/librte_ip_frag/rte_ipv6_reassembly.c:216:
+ mb = ip_frag_process(tbl, fp, dr, mb, ip_ofs, ip_len,$
ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 34 errors, 63 warnings, 259 lines checked
parent reply other threads:[~2018-05-14 14:23 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <2310632874.20180514172345@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180514142359.7542E1C8AF@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=kiselev99@gmail.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).