From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Dan Gora <dg@adax.com>
Subject: [dpdk-test-report] |WARNING| pw40294 [PATCH] kni: fix build on Centos 7.4 when Ethtool enabled
Date: Tue, 22 May 2018 02:20:44 +0200 (CEST) [thread overview]
Message-ID: <20180522002044.7FE9A1E34@dpdk.org> (raw)
In-Reply-To: <20180522001835.9843-1-dg@adax.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/40294
_coding style issues_
ERROR:SPACING: space required after that ',' (ctx:VxV)
#48: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3903:
+#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,2,0) ) \
^
ERROR:SPACING: space required after that ',' (ctx:VxV)
#48: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3903:
+#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,2,0) ) \
^
ERROR:SPACING: space prohibited after that open parenthesis '('
#48: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3903:
+#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,2,0) ) \
ERROR:SPACING: space prohibited before that close parenthesis ')'
#48: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3903:
+#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,2,0) ) \
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#48: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3903:
+#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,2,0) ) \
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#49: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3904:
+ || ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,4) ))$
ERROR:SPACING: space required after that ',' (ctx:VxV)
#49: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3904:
+ || ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,4) ))
^
ERROR:SPACING: space prohibited after that open parenthesis '('
#49: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3904:
+ || ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,4) ))
ERROR:SPACING: space prohibited before that close parenthesis ')'
#49: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3904:
+ || ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,4) ))
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#49: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3904:
+ || ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,4) ))
ERROR:SPACING: space required after that ',' (ctx:VxV)
#57: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3924:
+#elif ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,4) )
^
ERROR:SPACING: space prohibited after that open parenthesis '('
#57: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3924:
+#elif ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,4) )
ERROR:SPACING: space prohibited before that close parenthesis ')'
#57: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3924:
+#elif ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,4) )
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#57: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3924:
+#elif ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,4) )
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#59: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3926:
+ * is in the net_device_ops_extended struct */
total: 10 errors, 5 warnings, 20 lines checked
parent reply other threads:[~2018-05-22 0:20 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20180522001835.9843-1-dg@adax.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180522002044.7FE9A1E34@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=dg@adax.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).