From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 7FE9A1E34; Tue, 22 May 2018 02:20:44 +0200 (CEST)
In-Reply-To: <20180522001835.9843-1-dg@adax.com>
References: <20180522001835.9843-1-dg@adax.com>
To: test-report@dpdk.org
Cc: Dan Gora <dg@adax.com>
Message-Id: <20180522002044.7FE9A1E34@dpdk.org>
Date: Tue, 22 May 2018 02:20:44 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw40294 [PATCH] kni: fix build on
	Centos 7.4 when Ethtool enabled
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 22 May 2018 00:20:44 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/40294

_coding style issues_


ERROR:SPACING: space required after that ',' (ctx:VxV)
#48: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3903:
+#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,2,0) ) \
                                              ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#48: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3903:
+#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,2,0) ) \
                                                ^

ERROR:SPACING: space prohibited after that open parenthesis '('
#48: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3903:
+#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,2,0) ) \

ERROR:SPACING: space prohibited before that close parenthesis ')'
#48: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3903:
+#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,2,0) ) \

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#48: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3903:
+#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,2,0) ) \

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#49: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3904:
+    || ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,4) ))$

ERROR:SPACING: space required after that ',' (ctx:VxV)
#49: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3904:
+    || ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,4) ))
                                                     ^

ERROR:SPACING: space prohibited after that open parenthesis '('
#49: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3904:
+    || ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,4) ))

ERROR:SPACING: space prohibited before that close parenthesis ')'
#49: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3904:
+    || ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,4) ))

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#49: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3904:
+    || ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,4) ))

ERROR:SPACING: space required after that ',' (ctx:VxV)
#57: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3924:
+#elif ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,4) )
                                                    ^

ERROR:SPACING: space prohibited after that open parenthesis '('
#57: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3924:
+#elif ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,4) )

ERROR:SPACING: space prohibited before that close parenthesis ')'
#57: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3924:
+#elif ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,4) )

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#57: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3924:
+#elif ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,4) )

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#59: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3926:
+ * is in the net_device_ops_extended struct */

total: 10 errors, 5 warnings, 20 lines checked