* [dpdk-test-report] |WARNING| pw40294 [PATCH] kni: fix build on Centos 7.4 when Ethtool enabled
[not found] <20180522001835.9843-1-dg@adax.com>
@ 2018-05-22 0:20 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2018-05-22 0:20 UTC (permalink / raw)
To: test-report; +Cc: Dan Gora
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/40294
_coding style issues_
ERROR:SPACING: space required after that ',' (ctx:VxV)
#48: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3903:
+#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,2,0) ) \
^
ERROR:SPACING: space required after that ',' (ctx:VxV)
#48: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3903:
+#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,2,0) ) \
^
ERROR:SPACING: space prohibited after that open parenthesis '('
#48: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3903:
+#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,2,0) ) \
ERROR:SPACING: space prohibited before that close parenthesis ')'
#48: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3903:
+#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,2,0) ) \
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#48: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3903:
+#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,2,0) ) \
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#49: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3904:
+ || ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,4) ))$
ERROR:SPACING: space required after that ',' (ctx:VxV)
#49: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3904:
+ || ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,4) ))
^
ERROR:SPACING: space prohibited after that open parenthesis '('
#49: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3904:
+ || ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,4) ))
ERROR:SPACING: space prohibited before that close parenthesis ')'
#49: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3904:
+ || ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,4) ))
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#49: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3904:
+ || ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,4) ))
ERROR:SPACING: space required after that ',' (ctx:VxV)
#57: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3924:
+#elif ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,4) )
^
ERROR:SPACING: space prohibited after that open parenthesis '('
#57: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3924:
+#elif ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,4) )
ERROR:SPACING: space prohibited before that close parenthesis ')'
#57: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3924:
+#elif ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,4) )
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#57: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3924:
+#elif ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,4) )
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#59: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3926:
+ * is in the net_device_ops_extended struct */
total: 10 errors, 5 warnings, 20 lines checked
^ permalink raw reply [flat|nested] only message in thread