From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id ECFD91BA8F; Fri,  8 Jun 2018 16:18:55 +0200 (CEST)
In-Reply-To: <1528451833-3617-1-git-send-email-liang.j.ma@intel.com>
References: <1528451833-3617-1-git-send-email-liang.j.ma@intel.com>
To: test-report@dpdk.org
Cc: Liang Ma <liang.j.ma@intel.com>
Message-Id: <20180608141855.ECFD91BA8F@dpdk.org>
Date: Fri,  8 Jun 2018 16:18:55 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw40815 [PATCH v1 1/2]
	lib/librte_power: traffic pattern aware power control
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Jun 2018 14:18:56 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/40815

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#31: 
how many cycles it costs to handle each packet and determining the frequency

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#136: FILE: lib/librte_power/rte_empty_poll.c:1:
+/* SPDX-License-Identifier: BSD-3-Clause

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'poll_stats->thresh[poll_stats->cur_freq].threshold_percent'
#389: FILE: lib/librte_power/rte_empty_poll.c:254:
+		if (percent > poll_stats->thresh[poll_stats->cur_freq].
+				threshold_percent) {

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'poll_stats->thresh[poll_stats->cur_freq].threshold_percent'
#404: FILE: lib/librte_power/rte_empty_poll.c:269:
+		if (percent < poll_stats->thresh[poll_stats->cur_freq].
+				threshold_percent) {

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#418: FILE: lib/librte_power/rte_empty_poll.c:283:
+static int
+empty_poll_trainning(struct priority_worker *poll_stats,
+		uint32_t max_train_iter) {

total: 1 errors, 4 warnings, 682 lines checked