From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id B1FCE1BB0C; Fri,  8 Jun 2018 16:19:06 +0200 (CEST)
In-Reply-To: <20180608124155.140663-3-jasvinder.singh@intel.com>
References: <20180608124155.140663-3-jasvinder.singh@intel.com>
To: test-report@dpdk.org
Cc: Jasvinder Singh <jasvinder.singh@intel.com>
Message-Id: <20180608141906.B1FCE1BB0C@dpdk.org>
Date: Fri,  8 Jun 2018 16:19:06 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw40828 [PATCH 02/21] net/softnic: add
	software queue object
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Jun 2018 14:19:06 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/40828

_coding style issues_


WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#148: FILE: drivers/net/softnic/rte_eth_softnic_swq.c:1:
+/* SPDX-License-Identifier: BSD-3-Clause

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'name == NULL'
#210: FILE: drivers/net/softnic/rte_eth_softnic_swq.c:63:
+	if ((name == NULL) ||
+		swq_find(p, name) ||
+		(params == NULL) ||
+		(params->size == 0))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params == NULL'
#210: FILE: drivers/net/softnic/rte_eth_softnic_swq.c:63:
+	if ((name == NULL) ||
+		swq_find(p, name) ||
+		(params == NULL) ||
+		(params->size == 0))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params->size == 0'
#210: FILE: drivers/net/softnic/rte_eth_softnic_swq.c:63:
+	if ((name == NULL) ||
+		swq_find(p, name) ||
+		(params == NULL) ||
+		(params->size == 0))

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#221: FILE: drivers/net/softnic/rte_eth_softnic_swq.c:74:
+	r = rte_ring_create(

total: 0 errors, 1 warnings, 4 checks, 194 lines checked