* [dpdk-test-report] |WARNING| pw40830 [PATCH 04/21] net/softnic: add mempool object
[not found] <20180608124155.140663-5-jasvinder.singh@intel.com>
@ 2018-06-08 14:19 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2018-06-08 14:19 UTC (permalink / raw)
To: test-report; +Cc: Jasvinder Singh
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/40830
_coding style issues_
WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#134: FILE: drivers/net/softnic/rte_eth_softnic_mempool.c:1:
+/* SPDX-License-Identifier: BSD-3-Clause
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'name == NULL'
#198: FILE: drivers/net/softnic/rte_eth_softnic_mempool.c:65:
+ if ((name == NULL) ||
+ mempool_find(p, name) ||
+ (params == NULL) ||
+ (params->buffer_size < BUFFER_SIZE_MIN) ||
+ (params->pool_size == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params == NULL'
#198: FILE: drivers/net/softnic/rte_eth_softnic_mempool.c:65:
+ if ((name == NULL) ||
+ mempool_find(p, name) ||
+ (params == NULL) ||
+ (params->buffer_size < BUFFER_SIZE_MIN) ||
+ (params->pool_size == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params->buffer_size < BUFFER_SIZE_MIN'
#198: FILE: drivers/net/softnic/rte_eth_softnic_mempool.c:65:
+ if ((name == NULL) ||
+ mempool_find(p, name) ||
+ (params == NULL) ||
+ (params->buffer_size < BUFFER_SIZE_MIN) ||
+ (params->pool_size == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params->pool_size == 0'
#198: FILE: drivers/net/softnic/rte_eth_softnic_mempool.c:65:
+ if ((name == NULL) ||
+ mempool_find(p, name) ||
+ (params == NULL) ||
+ (params->buffer_size < BUFFER_SIZE_MIN) ||
+ (params->pool_size == 0))
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#210: FILE: drivers/net/softnic/rte_eth_softnic_mempool.c:77:
+ m = rte_pktmbuf_pool_create(
total: 0 errors, 1 warnings, 5 checks, 186 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2018-06-08 14:19 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20180608124155.140663-5-jasvinder.singh@intel.com>
2018-06-08 14:19 ` [dpdk-test-report] |WARNING| pw40830 [PATCH 04/21] net/softnic: add mempool object checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).