From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 751021BB29; Fri,  8 Jun 2018 16:19:12 +0200 (CEST)
In-Reply-To: <20180608124155.140663-8-jasvinder.singh@intel.com>
References: <20180608124155.140663-8-jasvinder.singh@intel.com>
To: test-report@dpdk.org
Cc: Jasvinder Singh <jasvinder.singh@intel.com>
Message-Id: <20180608141912.751021BB29@dpdk.org>
Date: Fri,  8 Jun 2018 16:19:12 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw40833 [PATCH 07/21] net/softnic: add
	port action profile
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Jun 2018 14:19:12 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/40833

_coding style issues_


WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#427: FILE: drivers/net/softnic/hash_func_arm64.h:1:
+/*-

CHECK:SPACING: spaces required around that ':' (ctx:VxV)
#463: FILE: drivers/net/softnic/hash_func_arm64.h:37:
+	__asm__("crc32cx %w[c], %w[c], %x[v]":[c] "+r" (crc):[v] "r" (val))
 	                                     ^

CHECK:SPACING: spaces required around that ':' (ctx:VxV)
#463: FILE: drivers/net/softnic/hash_func_arm64.h:37:
+	__asm__("crc32cx %w[c], %w[c], %x[v]":[c] "+r" (crc):[v] "r" (val))
 	                                                    ^

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#714: FILE: drivers/net/softnic/rte_eth_softnic_action.c:1:
+/* SPDX-License-Identifier: BSD-3-Clause

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'name == NULL'
#779: FILE: drivers/net/softnic/rte_eth_softnic_action.c:66:
+	if ((name == NULL) ||
+		port_in_action_profile_find(p, name) ||
+		(params == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params == NULL'
#779: FILE: drivers/net/softnic/rte_eth_softnic_action.c:66:
+	if ((name == NULL) ||
+		port_in_action_profile_find(p, name) ||
+		(params == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params->lb.f_hash == NULL'
#784: FILE: drivers/net/softnic/rte_eth_softnic_action.c:71:
+	if ((params->action_mask & (1LLU << RTE_PORT_IN_ACTION_LB)) &&
+		(params->lb.f_hash == NULL)) {

total: 0 errors, 2 warnings, 882 lines checked