From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jasvinder Singh <jasvinder.singh@intel.com>
Subject: [dpdk-test-report] |WARNING| pw40835 [PATCH 09/21] net/softnic: add pipeline object
Date: Fri, 8 Jun 2018 16:19:15 +0200 (CEST) [thread overview]
Message-ID: <20180608141915.E168C1BB3D@dpdk.org> (raw)
In-Reply-To: <20180608124155.140663-10-jasvinder.singh@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/40835
_coding style issues_
WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#293: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:1:
+/* SPDX-License-Identifier: BSD-3-Clause
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'name == NULL'
#385: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:93:
+ if ((name == NULL) ||
+ pipeline_find(softnic, name) ||
+ (params == NULL) ||
+ (params->timer_period_ms == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params == NULL'
#385: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:93:
+ if ((name == NULL) ||
+ pipeline_find(softnic, name) ||
+ (params == NULL) ||
+ (params->timer_period_ms == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params->timer_period_ms == 0'
#385: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:93:
+ if ((name == NULL) ||
+ pipeline_find(softnic, name) ||
+ (params == NULL) ||
+ (params->timer_period_ms == 0))
CHECK:SPACING: No space is necessary after a cast
#421: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:129:
+ pp.socket_id = (int) softnic->params.cpu_id;
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline_name == NULL'
#485: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:193:
+ if ((pipeline_name == NULL) ||
+ (params == NULL) ||
+ (params->burst_size == 0) ||
+ (params->burst_size > RTE_PORT_IN_BURST_SIZE_MAX))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params == NULL'
#485: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:193:
+ if ((pipeline_name == NULL) ||
+ (params == NULL) ||
+ (params->burst_size == 0) ||
+ (params->burst_size > RTE_PORT_IN_BURST_SIZE_MAX))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params->burst_size == 0'
#485: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:193:
+ if ((pipeline_name == NULL) ||
+ (params == NULL) ||
+ (params->burst_size == 0) ||
+ (params->burst_size > RTE_PORT_IN_BURST_SIZE_MAX))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params->burst_size > RTE_PORT_IN_BURST_SIZE_MAX'
#485: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:193:
+ if ((pipeline_name == NULL) ||
+ (params == NULL) ||
+ (params->burst_size == 0) ||
+ (params->burst_size > RTE_PORT_IN_BURST_SIZE_MAX))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tap == NULL'
#560: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:268:
+ if ((tap == NULL) || (mempool == NULL))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mempool == NULL'
#560: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:268:
+ if ((tap == NULL) || (mempool == NULL))
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#606: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:314:
+ status = rte_port_in_action_params_get(
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline == NULL'
#650: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:358:
+ if ((pipeline == NULL) ||
+ (port_id >= pipeline->n_ports_in) ||
+ (table_id >= pipeline->n_tables))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'port_id >= pipeline->n_ports_in'
#650: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:358:
+ if ((pipeline == NULL) ||
+ (port_id >= pipeline->n_ports_in) ||
+ (table_id >= pipeline->n_tables))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'table_id >= pipeline->n_tables'
#650: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:358:
+ if ((pipeline == NULL) ||
+ (port_id >= pipeline->n_ports_in) ||
+ (table_id >= pipeline->n_tables))
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#662: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:370:
+
+}
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline_name == NULL'
#694: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:402:
+ if ((pipeline_name == NULL) ||
+ (params == NULL) ||
+ (params->burst_size == 0) ||
+ (params->burst_size > RTE_PORT_IN_BURST_SIZE_MAX))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params == NULL'
#694: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:402:
+ if ((pipeline_name == NULL) ||
+ (params == NULL) ||
+ (params->burst_size == 0) ||
+ (params->burst_size > RTE_PORT_IN_BURST_SIZE_MAX))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params->burst_size == 0'
#694: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:402:
+ if ((pipeline_name == NULL) ||
+ (params == NULL) ||
+ (params->burst_size == 0) ||
+ (params->burst_size > RTE_PORT_IN_BURST_SIZE_MAX))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params->burst_size > RTE_PORT_IN_BURST_SIZE_MAX'
#694: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:402:
+ if ((pipeline_name == NULL) ||
+ (params == NULL) ||
+ (params->burst_size == 0) ||
+ (params->burst_size > RTE_PORT_IN_BURST_SIZE_MAX))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline_name == NULL'
#1005: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:713:
+ if ((pipeline_name == NULL) ||
+ (params == NULL))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params == NULL'
#1005: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:713:
+ if ((pipeline_name == NULL) ||
+ (params == NULL))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline == NULL'
#1010: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:718:
+ if ((pipeline == NULL) ||
+ (pipeline->n_tables >= RTE_PIPELINE_TABLE_MAX))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline->n_tables >= RTE_PIPELINE_TABLE_MAX'
#1010: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:718:
+ if ((pipeline == NULL) ||
+ (pipeline->n_tables >= RTE_PIPELINE_TABLE_MAX))
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1211: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:919:
+ status = rte_table_action_table_params_get(
total: 0 errors, 1 warnings, 1208 lines checked
parent reply other threads:[~2018-06-08 14:19 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20180608124155.140663-10-jasvinder.singh@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180608141915.E168C1BB3D@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).