From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id E168C1BB3D; Fri,  8 Jun 2018 16:19:15 +0200 (CEST)
In-Reply-To: <20180608124155.140663-10-jasvinder.singh@intel.com>
References: <20180608124155.140663-10-jasvinder.singh@intel.com>
To: test-report@dpdk.org
Cc: Jasvinder Singh <jasvinder.singh@intel.com>
Message-Id: <20180608141915.E168C1BB3D@dpdk.org>
Date: Fri,  8 Jun 2018 16:19:15 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw40835 [PATCH 09/21] net/softnic: add
	pipeline object
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Jun 2018 14:19:16 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/40835

_coding style issues_


WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#293: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:1:
+/* SPDX-License-Identifier: BSD-3-Clause

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'name == NULL'
#385: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:93:
+	if ((name == NULL) ||
+		pipeline_find(softnic, name) ||
+		(params == NULL) ||
+		(params->timer_period_ms == 0))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params == NULL'
#385: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:93:
+	if ((name == NULL) ||
+		pipeline_find(softnic, name) ||
+		(params == NULL) ||
+		(params->timer_period_ms == 0))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params->timer_period_ms == 0'
#385: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:93:
+	if ((name == NULL) ||
+		pipeline_find(softnic, name) ||
+		(params == NULL) ||
+		(params->timer_period_ms == 0))

CHECK:SPACING: No space is necessary after a cast
#421: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:129:
+	pp.socket_id = (int) softnic->params.cpu_id;

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline_name == NULL'
#485: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:193:
+	if ((pipeline_name == NULL) ||
+		(params == NULL) ||
+		(params->burst_size == 0) ||
+		(params->burst_size > RTE_PORT_IN_BURST_SIZE_MAX))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params == NULL'
#485: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:193:
+	if ((pipeline_name == NULL) ||
+		(params == NULL) ||
+		(params->burst_size == 0) ||
+		(params->burst_size > RTE_PORT_IN_BURST_SIZE_MAX))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params->burst_size == 0'
#485: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:193:
+	if ((pipeline_name == NULL) ||
+		(params == NULL) ||
+		(params->burst_size == 0) ||
+		(params->burst_size > RTE_PORT_IN_BURST_SIZE_MAX))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params->burst_size > RTE_PORT_IN_BURST_SIZE_MAX'
#485: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:193:
+	if ((pipeline_name == NULL) ||
+		(params == NULL) ||
+		(params->burst_size == 0) ||
+		(params->burst_size > RTE_PORT_IN_BURST_SIZE_MAX))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tap == NULL'
#560: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:268:
+		if ((tap == NULL) || (mempool == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mempool == NULL'
#560: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:268:
+		if ((tap == NULL) || (mempool == NULL))

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#606: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:314:
+		status = rte_port_in_action_params_get(

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline == NULL'
#650: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:358:
+	if ((pipeline == NULL) ||
+		(port_id >= pipeline->n_ports_in) ||
+		(table_id >= pipeline->n_tables))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'port_id >= pipeline->n_ports_in'
#650: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:358:
+	if ((pipeline == NULL) ||
+		(port_id >= pipeline->n_ports_in) ||
+		(table_id >= pipeline->n_tables))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'table_id >= pipeline->n_tables'
#650: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:358:
+	if ((pipeline == NULL) ||
+		(port_id >= pipeline->n_ports_in) ||
+		(table_id >= pipeline->n_tables))

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#662: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:370:
+
+}

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline_name == NULL'
#694: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:402:
+	if ((pipeline_name == NULL) ||
+		(params == NULL) ||
+		(params->burst_size == 0) ||
+		(params->burst_size > RTE_PORT_IN_BURST_SIZE_MAX))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params == NULL'
#694: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:402:
+	if ((pipeline_name == NULL) ||
+		(params == NULL) ||
+		(params->burst_size == 0) ||
+		(params->burst_size > RTE_PORT_IN_BURST_SIZE_MAX))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params->burst_size == 0'
#694: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:402:
+	if ((pipeline_name == NULL) ||
+		(params == NULL) ||
+		(params->burst_size == 0) ||
+		(params->burst_size > RTE_PORT_IN_BURST_SIZE_MAX))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params->burst_size > RTE_PORT_IN_BURST_SIZE_MAX'
#694: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:402:
+	if ((pipeline_name == NULL) ||
+		(params == NULL) ||
+		(params->burst_size == 0) ||
+		(params->burst_size > RTE_PORT_IN_BURST_SIZE_MAX))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline_name == NULL'
#1005: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:713:
+	if ((pipeline_name == NULL) ||
+		(params == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params == NULL'
#1005: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:713:
+	if ((pipeline_name == NULL) ||
+		(params == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline == NULL'
#1010: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:718:
+	if ((pipeline == NULL) ||
+		(pipeline->n_tables >= RTE_PIPELINE_TABLE_MAX))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline->n_tables >= RTE_PIPELINE_TABLE_MAX'
#1010: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:718:
+	if ((pipeline == NULL) ||
+		(pipeline->n_tables >= RTE_PIPELINE_TABLE_MAX))

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1211: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:919:
+		status = rte_table_action_table_params_get(

total: 0 errors, 1 warnings, 1208 lines checked