* [dpdk-test-report] |WARNING| pw40839 [PATCH 13/21] net/softnic: add connection agent
[not found] <20180608124155.140663-14-jasvinder.singh@intel.com>
@ 2018-06-08 14:19 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2018-06-08 14:19 UTC (permalink / raw)
To: test-report; +Cc: Jasvinder Singh
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/40839
_coding style issues_
WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#51: FILE: drivers/net/softnic/conn.c:1:
+/* SPDX-License-Identifier: BSD-3-Clause
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#99: FILE: drivers/net/softnic/conn.c:49:
+ if ((p == NULL) ||
+ (p->welcome == NULL) ||
+ (p->prompt == NULL) ||
+ (p->addr == NULL) ||
+ (p->buf_size == 0) ||
+ (p->msg_in_len_max == 0) ||
+ (p->msg_out_len_max == 0) ||
+ (p->msg_handle == NULL))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->welcome == NULL'
#99: FILE: drivers/net/softnic/conn.c:49:
+ if ((p == NULL) ||
+ (p->welcome == NULL) ||
+ (p->prompt == NULL) ||
+ (p->addr == NULL) ||
+ (p->buf_size == 0) ||
+ (p->msg_in_len_max == 0) ||
+ (p->msg_out_len_max == 0) ||
+ (p->msg_handle == NULL))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->prompt == NULL'
#99: FILE: drivers/net/softnic/conn.c:49:
+ if ((p == NULL) ||
+ (p->welcome == NULL) ||
+ (p->prompt == NULL) ||
+ (p->addr == NULL) ||
+ (p->buf_size == 0) ||
+ (p->msg_in_len_max == 0) ||
+ (p->msg_out_len_max == 0) ||
+ (p->msg_handle == NULL))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->addr == NULL'
#99: FILE: drivers/net/softnic/conn.c:49:
+ if ((p == NULL) ||
+ (p->welcome == NULL) ||
+ (p->prompt == NULL) ||
+ (p->addr == NULL) ||
+ (p->buf_size == 0) ||
+ (p->msg_in_len_max == 0) ||
+ (p->msg_out_len_max == 0) ||
+ (p->msg_handle == NULL))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->buf_size == 0'
#99: FILE: drivers/net/softnic/conn.c:49:
+ if ((p == NULL) ||
+ (p->welcome == NULL) ||
+ (p->prompt == NULL) ||
+ (p->addr == NULL) ||
+ (p->buf_size == 0) ||
+ (p->msg_in_len_max == 0) ||
+ (p->msg_out_len_max == 0) ||
+ (p->msg_handle == NULL))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->msg_in_len_max == 0'
#99: FILE: drivers/net/softnic/conn.c:49:
+ if ((p == NULL) ||
+ (p->welcome == NULL) ||
+ (p->prompt == NULL) ||
+ (p->addr == NULL) ||
+ (p->buf_size == 0) ||
+ (p->msg_in_len_max == 0) ||
+ (p->msg_out_len_max == 0) ||
+ (p->msg_handle == NULL))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->msg_out_len_max == 0'
#99: FILE: drivers/net/softnic/conn.c:49:
+ if ((p == NULL) ||
+ (p->welcome == NULL) ||
+ (p->prompt == NULL) ||
+ (p->addr == NULL) ||
+ (p->buf_size == 0) ||
+ (p->msg_in_len_max == 0) ||
+ (p->msg_out_len_max == 0) ||
+ (p->msg_handle == NULL))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->msg_handle == NULL'
#99: FILE: drivers/net/softnic/conn.c:49:
+ if ((p == NULL) ||
+ (p->welcome == NULL) ||
+ (p->prompt == NULL) ||
+ (p->addr == NULL) ||
+ (p->buf_size == 0) ||
+ (p->msg_in_len_max == 0) ||
+ (p->msg_out_len_max == 0) ||
+ (p->msg_handle == NULL))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'conn->welcome == NULL'
#124: FILE: drivers/net/softnic/conn.c:74:
+ if ((conn->welcome == NULL) ||
+ (conn->prompt == NULL) ||
+ (conn->buf == NULL) ||
+ (conn->msg_in == NULL) ||
+ (conn->msg_out == NULL)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'conn->prompt == NULL'
#124: FILE: drivers/net/softnic/conn.c:74:
+ if ((conn->welcome == NULL) ||
+ (conn->prompt == NULL) ||
+ (conn->buf == NULL) ||
+ (conn->msg_in == NULL) ||
+ (conn->msg_out == NULL)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'conn->buf == NULL'
#124: FILE: drivers/net/softnic/conn.c:74:
+ if ((conn->welcome == NULL) ||
+ (conn->prompt == NULL) ||
+ (conn->buf == NULL) ||
+ (conn->msg_in == NULL) ||
+ (conn->msg_out == NULL)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'conn->msg_in == NULL'
#124: FILE: drivers/net/softnic/conn.c:74:
+ if ((conn->welcome == NULL) ||
+ (conn->prompt == NULL) ||
+ (conn->buf == NULL) ||
+ (conn->msg_in == NULL) ||
+ (conn->msg_out == NULL)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'conn->msg_out == NULL'
#124: FILE: drivers/net/softnic/conn.c:74:
+ if ((conn->welcome == NULL) ||
+ (conn->prompt == NULL) ||
+ (conn->buf == NULL) ||
+ (conn->msg_in == NULL) ||
+ (conn->msg_out == NULL)) {
CHECK:SPACING: No space is necessary after a cast
#146: FILE: drivers/net/softnic/conn.c:96:
+ (struct sockaddr *) &server_address,
CHECK:SPACING: No space is necessary after a cast
#218: FILE: drivers/net/softnic/conn.c:168:
+ (struct sockaddr *) &client_address,
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'errno == EAGAIN'
#222: FILE: drivers/net/softnic/conn.c:172:
+ if ((errno == EAGAIN) || (errno == EWOULDBLOCK))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'errno == EWOULDBLOCK'
#222: FILE: drivers/net/softnic/conn.c:172:
+ if ((errno == EAGAIN) || (errno == EWOULDBLOCK))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'errno == EAGAIN'
#273: FILE: drivers/net/softnic/conn.c:223:
+ if ((errno == EAGAIN) || (errno == EWOULDBLOCK))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'errno == EWOULDBLOCK'
#273: FILE: drivers/net/softnic/conn.c:223:
+ if ((errno == EAGAIN) || (errno == EWOULDBLOCK))
total: 0 errors, 1 warnings, 19 checks, 569 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2018-06-08 14:19 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20180608124155.140663-14-jasvinder.singh@intel.com>
2018-06-08 14:19 ` [dpdk-test-report] |WARNING| pw40839 [PATCH 13/21] net/softnic: add connection agent checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).