From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jasvinder Singh <jasvinder.singh@intel.com>
Subject: [dpdk-test-report] |WARNING| pw40841 [PATCH 15/21] net/softnic: add cli to enable and disable pipeline
Date: Fri, 8 Jun 2018 16:19:26 +0200 (CEST) [thread overview]
Message-ID: <20180608141926.32FF61BB6F@dpdk.org> (raw)
In-Reply-To: <20180608124155.140663-16-jasvinder.singh@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/40841
_coding style issues_
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 5'
#130: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1760:
+ if ((n_tokens >= 5) &&
+ (strcmp(tokens[4], "enable") == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 5'
#137: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1767:
+ if ((n_tokens >= 5) &&
+ (strcmp(tokens[4], "disable") == 0)) {
CHECK:SPACING: No space is necessary after a cast
#243: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:162:
+ status = rte_ring_sc_dequeue(msgq_rsp, (void **) &rsp);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'thread_id >= RTE_MAX_LCORE'
#263: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:182:
+ if ((thread_id >= RTE_MAX_LCORE) ||
+ (p == NULL) ||
+ (p->n_ports_in == 0) ||
+ (p->n_ports_out == 0) ||
+ (p->n_tables == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#263: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:182:
+ if ((thread_id >= RTE_MAX_LCORE) ||
+ (p == NULL) ||
+ (p->n_ports_in == 0) ||
+ (p->n_ports_out == 0) ||
+ (p->n_tables == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->n_ports_in == 0'
#263: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:182:
+ if ((thread_id >= RTE_MAX_LCORE) ||
+ (p == NULL) ||
+ (p->n_ports_in == 0) ||
+ (p->n_ports_out == 0) ||
+ (p->n_tables == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->n_ports_out == 0'
#263: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:182:
+ if ((thread_id >= RTE_MAX_LCORE) ||
+ (p == NULL) ||
+ (p->n_ports_in == 0) ||
+ (p->n_ports_out == 0) ||
+ (p->n_tables == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->n_tables == 0'
#263: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:182:
+ if ((thread_id >= RTE_MAX_LCORE) ||
+ (p == NULL) ||
+ (p->n_ports_in == 0) ||
+ (p->n_ports_out == 0) ||
+ (p->n_tables == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 't->enabled == 0'
#271: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:190:
+ if ((t->enabled == 0) ||
+ p->enabled)
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'thread_id >= RTE_MAX_LCORE'
#356: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:275:
+ if ((thread_id >= RTE_MAX_LCORE) ||
+ (p == NULL))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#356: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:275:
+ if ((thread_id >= RTE_MAX_LCORE) ||
+ (p == NULL))
CHECK:SPACING: No space is necessary after a cast
#444: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:382:
+ struct thread_msg_rsp *rsp = (struct thread_msg_rsp *) req;
CHECK:SPACING: No space is necessary after a cast
#480: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:418:
+ struct thread_msg_rsp *rsp = (struct thread_msg_rsp *) req;
total: 0 errors, 0 warnings, 13 checks, 485 lines checked
parent reply other threads:[~2018-06-08 14:19 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20180608124155.140663-16-jasvinder.singh@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180608141926.32FF61BB6F@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).