From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 746C01BA9A; Fri, 8 Jun 2018 16:19:32 +0200 (CEST) In-Reply-To: <20180608124155.140663-18-jasvinder.singh@intel.com> References: <20180608124155.140663-18-jasvinder.singh@intel.com> To: test-report@dpdk.org Cc: Jasvinder Singh Message-Id: <20180608141932.746C01BA9A@dpdk.org> Date: Fri, 8 Jun 2018 16:19:32 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw40843 [PATCH 17/21] net/softnic: add cli to read pipeline port and table stats X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jun 2018 14:19:32 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/40843 _coding style issues_ CHECK:CAMELCASE: Avoid CamelCase: #39: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1476: + "Pkts in: %" PRIu64 " " \ CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens != 7' #55: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1492: + if ((n_tokens != 7) && (n_tokens != 8)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens != 8' #55: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1492: + if ((n_tokens != 7) && (n_tokens != 8)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens != 7' #140: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1666: + if ((n_tokens != 7) && (n_tokens != 8)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens != 8' #140: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1666: + if ((n_tokens != 7) && (n_tokens != 8)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens != 6' #221: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1747: + if ((n_tokens != 6) && (n_tokens != 7)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens != 7' #221: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1747: + if ((n_tokens != 6) && (n_tokens != 7)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 6' #311: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3584: + if ((n_tokens >= 6) && + (strcmp(tokens[2], "port") == 0) && + (strcmp(tokens[3], "in") == 0) && (strcmp(tokens[5], "enable") == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 6' #321: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3602: + if ((n_tokens >= 6) && + (strcmp(tokens[2], "port") == 0) && + (strcmp(tokens[3], "out") == 0) && + (strcmp(tokens[5], "stats") == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 5' #330: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3611: + if ((n_tokens >= 5) && + (strcmp(tokens[2], "table") == 0) && + (strcmp(tokens[4], "stats") == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 7' #346: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3663: + if ((n_tokens >= 7) && + (strcmp(tokens[2], "table") == 0) && + (strcmp(tokens[4], "rule") == 0) && + (strcmp(tokens[5], "read") == 0) && + (strcmp(tokens[6], "stats") == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline_name == NULL' #534: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:661: + if ((pipeline_name == NULL) || + (stats == NULL)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'stats == NULL' #534: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:661: + if ((pipeline_name == NULL) || + (stats == NULL)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL' #539: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:666: + if ((p == NULL) || + (p->enabled == 0) || + (port_id >= p->n_ports_in)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->enabled == 0' #539: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:666: + if ((p == NULL) || + (p->enabled == 0) || + (port_id >= p->n_ports_in)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'port_id >= p->n_ports_in' #539: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:666: + if ((p == NULL) || + (p->enabled == 0) || + (port_id >= p->n_ports_in)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline_name == NULL' #591: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:796: + if ((pipeline_name == NULL) || + (stats == NULL)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'stats == NULL' #591: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:796: + if ((pipeline_name == NULL) || + (stats == NULL)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL' #596: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:801: + if ((p == NULL) || + (p->enabled == 0) || + (port_id >= p->n_ports_out)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->enabled == 0' #596: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:801: + if ((p == NULL) || + (p->enabled == 0) || + (port_id >= p->n_ports_out)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'port_id >= p->n_ports_out' #596: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:801: + if ((p == NULL) || + (p->enabled == 0) || + (port_id >= p->n_ports_out)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline_name == NULL' #640: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:845: + if ((pipeline_name == NULL) || + (stats == NULL)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'stats == NULL' #640: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:845: + if ((pipeline_name == NULL) || + (stats == NULL)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL' #645: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:850: + if ((p == NULL) || + (p->enabled == 0) || + (table_id >= p->n_tables)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->enabled == 0' #645: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:850: + if ((p == NULL) || + (p->enabled == 0) || + (table_id >= p->n_tables)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'table_id >= p->n_tables' #645: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:850: + if ((p == NULL) || + (p->enabled == 0) || + (table_id >= p->n_tables)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline_name == NULL' #697: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1319: + if ((pipeline_name == NULL) || + (data == NULL) || + (stats == NULL)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'data == NULL' #697: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1319: + if ((pipeline_name == NULL) || + (data == NULL) || + (stats == NULL)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'stats == NULL' #697: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1319: + if ((pipeline_name == NULL) || + (data == NULL) || + (stats == NULL)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL' #703: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1325: + if ((p == NULL) || + (p->enabled == 0) || + (table_id >= p->n_tables)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->enabled == 0' #703: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1325: + if ((p == NULL) || + (p->enabled == 0) || + (table_id >= p->n_tables)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'table_id >= p->n_tables' #703: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1325: + if ((p == NULL) || + (p->enabled == 0) || + (table_id >= p->n_tables)) CHECK:SPACING: No space is necessary after a cast #745: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1388: + struct pipeline_msg_rsp *rsp = (struct pipeline_msg_rsp *) req; CHECK:SPACING: No space is necessary after a cast #769: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1430: + struct pipeline_msg_rsp *rsp = (struct pipeline_msg_rsp *) req; CHECK:SPACING: No space is necessary after a cast #785: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1446: + struct pipeline_msg_rsp *rsp = (struct pipeline_msg_rsp *) req; CHECK:SPACING: No space is necessary after a cast #808: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:2165: + struct pipeline_msg_rsp *rsp = (struct pipeline_msg_rsp *) req; total: 0 errors, 0 warnings, 36 checks, 802 lines checked