From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 2C83D1BB0B; Fri, 8 Jun 2018 16:19:34 +0200 (CEST) In-Reply-To: <20180608124155.140663-19-jasvinder.singh@intel.com> References: <20180608124155.140663-19-jasvinder.singh@intel.com> To: test-report@dpdk.org Cc: Jasvinder Singh Message-Id: <20180608141934.2C83D1BB0B@dpdk.org> Date: Fri, 8 Jun 2018 16:19:34 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw40844 [PATCH 18/21] net/softnic: add cli for meter action X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jun 2018 14:19:34 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/40844 _coding style issues_ CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'dscp_table == NULL' #278: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3644: + if ((dscp_table == NULL) || + (file_name == NULL) || + (line_number == NULL)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'file_name == NULL' #278: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3644: + if ((dscp_table == NULL) || + (file_name == NULL) || + (line_number == NULL)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'line_number == NULL' #278: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3644: + if ((dscp_table == NULL) || + (file_name == NULL) || + (line_number == NULL)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'dscp >= RTE_DIM(dscp_table->entry)' #315: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3681: + if ((dscp >= RTE_DIM(dscp_table->entry)) || + (n_tokens != RTE_DIM(tokens)) || + parser_read_uint32(&tc_id, tokens[0]) || + (tc_id >= RTE_TABLE_ACTION_TC_MAX) || + parser_read_uint32(&tc_queue_id, tokens[1]) || + (tc_queue_id >= RTE_TABLE_ACTION_TC_QUEUE_MAX) || + (strlen(tokens[2]) != 1)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens != RTE_DIM(tokens)' #315: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3681: + if ((dscp >= RTE_DIM(dscp_table->entry)) || + (n_tokens != RTE_DIM(tokens)) || + parser_read_uint32(&tc_id, tokens[0]) || + (tc_id >= RTE_TABLE_ACTION_TC_MAX) || + parser_read_uint32(&tc_queue_id, tokens[1]) || + (tc_queue_id >= RTE_TABLE_ACTION_TC_QUEUE_MAX) || + (strlen(tokens[2]) != 1)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tc_id >= RTE_TABLE_ACTION_TC_MAX' #315: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3681: + if ((dscp >= RTE_DIM(dscp_table->entry)) || + (n_tokens != RTE_DIM(tokens)) || + parser_read_uint32(&tc_id, tokens[0]) || + (tc_id >= RTE_TABLE_ACTION_TC_MAX) || + parser_read_uint32(&tc_queue_id, tokens[1]) || + (tc_queue_id >= RTE_TABLE_ACTION_TC_QUEUE_MAX) || + (strlen(tokens[2]) != 1)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tc_queue_id >= RTE_TABLE_ACTION_TC_QUEUE_MAX' #315: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3681: + if ((dscp >= RTE_DIM(dscp_table->entry)) || + (n_tokens != RTE_DIM(tokens)) || + parser_read_uint32(&tc_id, tokens[0]) || + (tc_id >= RTE_TABLE_ACTION_TC_MAX) || + parser_read_uint32(&tc_queue_id, tokens[1]) || + (tc_queue_id >= RTE_TABLE_ACTION_TC_QUEUE_MAX) || + (strlen(tokens[2]) != 1)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 8' #422: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:4053: + if ((n_tokens >= 8) && + (strcmp(tokens[2], "table") == 0) && + (strcmp(tokens[4], "meter") == 0) && + (strcmp(tokens[5], "profile") == 0) && + (strcmp(tokens[7], "add") == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 8' #432: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:4063: + if ((n_tokens >= 8) && + (strcmp(tokens[2], "table") == 0) && + (strcmp(tokens[4], "meter") == 0) && + (strcmp(tokens[5], "profile") == 0) && + (strcmp(tokens[7], "delete") == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 7' #442: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:4073: + if ((n_tokens >= 7) && + (strcmp(tokens[2], "table") == 0) && + (strcmp(tokens[4], "rule") == 0) && + (strcmp(tokens[5], "read") == 0) && + (strcmp(tokens[6], "meter") == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 5' #452: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:4083: + if ((n_tokens >= 5) && + (strcmp(tokens[2], "table") == 0) && + (strcmp(tokens[4], "dscp") == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline_name == NULL' #592: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1402: + if ((pipeline_name == NULL) || + (profile == NULL)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'profile == NULL' #592: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1402: + if ((pipeline_name == NULL) || + (profile == NULL)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL' #597: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1407: + if ((p == NULL) || + (p->enabled == 0) || + (table_id >= p->n_tables)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->enabled == 0' #597: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1407: + if ((p == NULL) || + (p->enabled == 0) || + (table_id >= p->n_tables)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'table_id >= p->n_tables' #597: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1407: + if ((p == NULL) || + (p->enabled == 0) || + (table_id >= p->n_tables)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL' #643: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1453: + if ((p == NULL) || + (p->enabled == 0) || + (table_id >= p->n_tables)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->enabled == 0' #643: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1453: + if ((p == NULL) || + (p->enabled == 0) || + (table_id >= p->n_tables)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'table_id >= p->n_tables' #643: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1453: + if ((p == NULL) || + (p->enabled == 0) || + (table_id >= p->n_tables)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline_name == NULL' #687: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1497: + if ((pipeline_name == NULL) || + (data == NULL) || + (stats == NULL)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'data == NULL' #687: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1497: + if ((pipeline_name == NULL) || + (data == NULL) || + (stats == NULL)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'stats == NULL' #687: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1497: + if ((pipeline_name == NULL) || + (data == NULL) || + (stats == NULL)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL' #693: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1503: + if ((p == NULL) || + (p->enabled == 0) || + (table_id >= p->n_tables)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->enabled == 0' #693: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1503: + if ((p == NULL) || + (p->enabled == 0) || + (table_id >= p->n_tables)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'table_id >= p->n_tables' #693: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1503: + if ((p == NULL) || + (p->enabled == 0) || + (table_id >= p->n_tables)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline_name == NULL' #739: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1549: + if ((pipeline_name == NULL) || + (dscp_table == NULL)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'dscp_table == NULL' #739: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1549: + if ((pipeline_name == NULL) || + (dscp_table == NULL)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL' #744: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1554: + if ((p == NULL) || + (p->enabled == 0) || + (table_id >= p->n_tables)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->enabled == 0' #744: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1554: + if ((p == NULL) || + (p->enabled == 0) || + (table_id >= p->n_tables)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'table_id >= p->n_tables' #744: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1554: + if ((p == NULL) || + (p->enabled == 0) || + (table_id >= p->n_tables)) CHECK:SPACING: No space is necessary after a cast #786: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:2411: + struct pipeline_msg_rsp *rsp = (struct pipeline_msg_rsp *) req; CHECK:SPACING: No space is necessary after a cast #804: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:2429: + struct pipeline_msg_rsp *rsp = (struct pipeline_msg_rsp *) req; CHECK:SPACING: No space is necessary after a cast #820: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:2445: + struct pipeline_msg_rsp *rsp = (struct pipeline_msg_rsp *) req; CHECK:SPACING: No space is necessary after a cast #840: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:2465: + struct pipeline_msg_rsp *rsp = (struct pipeline_msg_rsp *) req; total: 0 errors, 0 warnings, 34 checks, 831 lines checked