automatic DPDK test reports
 help / color / mirror / Atom feed
* [dpdk-test-report] |WARNING| pw40845 [PATCH 19/21] net/softnic: add cli for ttl action
       [not found] <20180608124155.140663-20-jasvinder.singh@intel.com>
@ 2018-06-08 14:19 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2018-06-08 14:19 UTC (permalink / raw)
  To: test-report; +Cc: Jasvinder Singh

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/40845

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 7'
#55: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:4104:
+		if ((n_tokens >= 7) &&
+			(strcmp(tokens[2], "table") == 0) &&
+			(strcmp(tokens[4], "rule") == 0) &&
+			(strcmp(tokens[5], "read") == 0) &&
+			(strcmp(tokens[6], "ttl") == 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline_name == NULL'
#155: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1611:
+	if ((pipeline_name == NULL) ||
+		(data == NULL) ||
+		(stats == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'data == NULL'
#155: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1611:
+	if ((pipeline_name == NULL) ||
+		(data == NULL) ||
+		(stats == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'stats == NULL'
#155: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1611:
+	if ((pipeline_name == NULL) ||
+		(data == NULL) ||
+		(stats == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#161: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1617:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(table_id >= p->n_tables))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->enabled == 0'
#161: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1617:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(table_id >= p->n_tables))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'table_id >= p->n_tables'
#161: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1617:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(table_id >= p->n_tables))

CHECK:SPACING: No space is necessary after a cast
#204: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:2547:
+	struct pipeline_msg_rsp *rsp = (struct pipeline_msg_rsp *) req;

total: 0 errors, 0 warnings, 8 checks, 183 lines checked

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2018-06-08 14:19 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20180608124155.140663-20-jasvinder.singh@intel.com>
2018-06-08 14:19 ` [dpdk-test-report] |WARNING| pw40845 [PATCH 19/21] net/softnic: add cli for ttl action checkpatch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).