automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [dpdk-test-report] |WARNING| pw40882 [PATCH v10 3/5] net/netvsc: add hyper-v netvsc network device
Date: Fri,  8 Jun 2018 19:00:49 +0200 (CEST)	[thread overview]
Message-ID: <20180608170049.828941BB3D@dpdk.org> (raw)
In-Reply-To: <20180608165920.12228-4-stephen@networkplumber.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/40882

_coding style issues_


WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#160: FILE: drivers/net/netvsc/hn_ethdev.c:1:
+/* SPDX-License-Identifier: BSD-3-Clause

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#348: FILE: drivers/net/netvsc/hn_ethdev.c:189:
+	dev_info->flow_type_rss_offloads
+		= ETH_RSS_IPV4 | ETH_RSS_IPV6 | ETH_RSS_TCP | ETH_RSS_UDP;

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#451: FILE: drivers/net/netvsc/hn_ethdev.c:292:
+	const struct rte_eth_rss_conf *rss_conf
+		= &dev_conf->rx_adv_conf.rss_conf;

CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#461: FILE: drivers/net/netvsc/hn_ethdev.c:302:
+			    "unsupported TX offload: %#" PRIx64,

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#621: FILE: drivers/net/netvsc/hn_ethdev.c:462:
+	const unsigned int nstats
+		= dev->data->nb_tx_queues * RTE_DIM(hn_stat_strings)

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#966: FILE: drivers/net/netvsc/hn_nvs.c:1:
+/* SPDX-License-Identifier: BSD-3-Clause

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#1758: FILE: drivers/net/netvsc/hn_rndis.c:1:
+/* SPDX-License-Identifier: BSD-3-Clause

CHECK:CAMELCASE: Avoid CamelCase: <PRIx32>
#2477: FILE: drivers/net/netvsc/hn_rndis.c:720:
+		PMD_DRV_LOG(ERR, "exec RNDIS set %#" PRIx32 " failed",

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#2893: FILE: drivers/net/netvsc/hn_rxtx.c:1:
+/* SPDX-License-Identifier: BSD-3-Clause

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#3333: FILE: drivers/net/netvsc/hn_rxtx.c:441:
+		struct rte_eth_dev *dev
+			= &rte_eth_devices[rxq->port_id];

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ofs' - possible side-effects?
#3417: FILE: drivers/net/netvsc/hn_rxtx.c:525:
+#define IS_OFFSET_INVALID(ofs)			\
+	((ofs) < RNDIS_PACKET_MSG_OFFSET_MIN ||	\
+	 ((ofs) & RNDIS_PACKET_MSG_OFFSET_ALIGNMASK))

total: 0 errors, 4 warnings, 4929 lines checked

           reply	other threads:[~2018-06-08 17:00 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20180608165920.12228-4-stephen@networkplumber.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180608170049.828941BB3D@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).