From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id CAD511BEF6; Fri, 15 Jun 2018 18:54:31 +0200 (CEST)
In-Reply-To: <20180615165224.25004-13-jasvinder.singh@intel.com>
References: <20180615165224.25004-13-jasvinder.singh@intel.com>
To: test-report@dpdk.org
Cc: Jasvinder Singh <jasvinder.singh@intel.com>
Message-Id: <20180615165431.CAD511BEF6@dpdk.org>
Date: Fri, 15 Jun 2018 18:54:31 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw41206 [v2] [PATCH 12/22]
	net/softnic: add cli interface
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Jun 2018 16:54:32 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/41206

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'string == NULL'
#305: FILE: drivers/net/softnic/parser.c:257:
+	if ((string == NULL) ||
+		(tokens == NULL) ||
+		(*n_tokens < 1))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tokens == NULL'
#305: FILE: drivers/net/softnic/parser.c:257:
+	if ((string == NULL) ||
+		(tokens == NULL) ||
+		(*n_tokens < 1))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i == *n_tokens'
#316: FILE: drivers/net/softnic/parser.c:268:
+	if ((i == *n_tokens) &&
+		(NULL != strtok_r(string, PARSE_DELIMITER, &string)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'NULL != strtok_r(string, PARSE_DELIMITER, &string)'
#316: FILE: drivers/net/softnic/parser.c:268:
+	if ((i == *n_tokens) &&
+		(NULL != strtok_r(string, PARSE_DELIMITER, &string)))

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#317: FILE: drivers/net/softnic/parser.c:269:
+		(NULL != strtok_r(string, PARSE_DELIMITER, &string)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'src == NULL'
#331: FILE: drivers/net/softnic/parser.c:283:
+	if ((src == NULL) ||
+		(dst == NULL) ||
+		(size == NULL) ||
+		(*size == 0))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'dst == NULL'
#331: FILE: drivers/net/softnic/parser.c:283:
+	if ((src == NULL) ||
+		(dst == NULL) ||
+		(size == NULL) ||
+		(*size == 0))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'size == NULL'
#331: FILE: drivers/net/softnic/parser.c:283:
+	if ((src == NULL) ||
+		(dst == NULL) ||
+		(size == NULL) ||
+		(*size == 0))

CHECK:SPACING: No space is necessary after a cast
#391: FILE: drivers/net/softnic/parser.c:343:
+		labels[count++] = (uint32_t) value;

CHECK:BRACES: braces {} should be used on all arms of this statement
#425: FILE: drivers/net/softnic/parser.c:377:
+		if (pch != NULL) {
[...]
+		} else if (ch == '.' && saw_digit) {
[...]
+		} else
[...]

CHECK:BRACES: Unbalanced braces around else statement
#441: FILE: drivers/net/softnic/parser.c:393:
+		} else

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#473: FILE: drivers/net/softnic/parser.c:425:
+	unsigned dbloct_count = 0;

CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#483: FILE: drivers/net/softnic/parser.c:435:
+	saw_xdigit = count_xdigit = 0;

CHECK:SPACING: No space is necessary after a cast
#515: FILE: drivers/net/softnic/parser.c:467:
+			*tp++ = (unsigned char) ((val >> 8) & 0xff);

CHECK:SPACING: No space is necessary after a cast
#516: FILE: drivers/net/softnic/parser.c:468:
+			*tp++ = (unsigned char) (val & 0xff);

CHECK:SPACING: No space is necessary after a cast
#535: FILE: drivers/net/softnic/parser.c:487:
+		*tp++ = (unsigned char) ((val >> 8) & 0xff);

CHECK:SPACING: No space is necessary after a cast
#536: FILE: drivers/net/softnic/parser.c:488:
+		*tp++ = (unsigned char) (val & 0xff);

WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(o)
#578: FILE: drivers/net/softnic/parser.c:530:
+	} while (++i != sizeof(o) / sizeof(o[0]) && end[0] != 0);

CHECK:BRACES: braces {} should be used on all arms of this statement
#585: FILE: drivers/net/softnic/parser.c:537:
+	if (i == ETHER_ADDR_LEN) {
[...]
+	} else if (i == ETHER_ADDR_LEN / 2) {
[...]
+	} else
[...]

CHECK:BRACES: Unbalanced braces around else statement
#600: FILE: drivers/net/softnic/parser.c:552:
+	} else

total: 0 errors, 3 warnings, 17 checks, 899 lines checked