[dpdk-test-report] |WARNING| pw41209 [v2] [PATCH 15/22] net/softnic: add cli to enable and disable pipeline

[dpdk-test-report] |WARNING| pw41209 [v2] [PATCH 15/22] net/softnic: add cli to enable and disable pipeline

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/41209

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 5'
#129: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1779:
+		if ((n_tokens >= 5) &&
+			(strcmp(tokens[4], "enable") == 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 5'
#136: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1786:
+		if ((n_tokens >= 5) &&
+			(strcmp(tokens[4], "disable") == 0)) {

CHECK:SPACING: No space is necessary after a cast
#242: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:162:
+		status = rte_ring_sc_dequeue(msgq_rsp, (void **) &rsp);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'thread_id >= RTE_MAX_LCORE'
#262: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:182:
+	if ((thread_id >= RTE_MAX_LCORE) ||
+		(p == NULL) ||
+		(p->n_ports_in == 0) ||
+		(p->n_ports_out == 0) ||
+		(p->n_tables == 0))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#262: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:182:
+	if ((thread_id >= RTE_MAX_LCORE) ||
+		(p == NULL) ||
+		(p->n_ports_in == 0) ||
+		(p->n_ports_out == 0) ||
+		(p->n_tables == 0))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->n_ports_in == 0'
#262: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:182:
+	if ((thread_id >= RTE_MAX_LCORE) ||
+		(p == NULL) ||
+		(p->n_ports_in == 0) ||
+		(p->n_ports_out == 0) ||
+		(p->n_tables == 0))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->n_ports_out == 0'
#262: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:182:
+	if ((thread_id >= RTE_MAX_LCORE) ||
+		(p == NULL) ||
+		(p->n_ports_in == 0) ||
+		(p->n_ports_out == 0) ||
+		(p->n_tables == 0))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->n_tables == 0'
#262: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:182:
+	if ((thread_id >= RTE_MAX_LCORE) ||
+		(p == NULL) ||
+		(p->n_ports_in == 0) ||
+		(p->n_ports_out == 0) ||
+		(p->n_tables == 0))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 't->enabled == 0'
#270: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:190:
+	if ((t->enabled == 0) ||
+		p->enabled)

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'thread_id >= RTE_MAX_LCORE'
#355: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:275:
+	if ((thread_id >= RTE_MAX_LCORE) ||
+		(p == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#355: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:275:
+	if ((thread_id >= RTE_MAX_LCORE) ||
+		(p == NULL))

CHECK:SPACING: No space is necessary after a cast
#443: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:382:
+	struct thread_msg_rsp *rsp = (struct thread_msg_rsp *) req;

CHECK:SPACING: No space is necessary after a cast
#479: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:418:
+	struct thread_msg_rsp *rsp = (struct thread_msg_rsp *) req;

total: 0 errors, 0 warnings, 13 checks, 485 lines checked