From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jasvinder Singh <jasvinder.singh@intel.com>
Subject: [dpdk-test-report] |WARNING| pw41210 [v2] [PATCH 16/22] net/softnic: add cli for pipeline table entries
Date: Fri, 15 Jun 2018 18:54:45 +0200 (CEST) [thread overview]
Message-ID: <20180615165445.BC4FC1C0DA@dpdk.org> (raw)
In-Reply-To: <20180615165224.25004-17-jasvinder.singh@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/41210
_coding style issues_
CHECK:SPACING: No space is necessary after a cast
#436: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1800:
+ (struct pkt_key_ipv4_5tuple *) m->match.hash.key;
CHECK:SPACING: No space is necessary after a cast
#518: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1848:
+ (struct pkt_key_ipv6_5tuple *) m->match.hash.key;
CHECK:SPACING: No space is necessary after a cast
#571: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1896:
+ (struct pkt_key_ipv4_addr *) m->match.hash.key;
CHECK:SPACING: No space is necessary after a cast
#593: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1918:
+ (struct pkt_key_ipv6_addr *) m->match.hash.key;
CHECK:SPACING: No space is necessary after a cast
#615: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1940:
+ (struct pkt_key_qinq *) m->match.hash.key;
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'svlan > 0xFFF'
#624: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1949:
+ if ((softnic_parser_read_uint16(&svlan, tokens[3]) != 0) ||
+ (svlan > 0xFFF)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'cvlan > 0xFFF'
#631: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1956:
+ if ((softnic_parser_read_uint16(&cvlan, tokens[4]) != 0) ||
+ (cvlan > 0xFFF)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens == 0'
#739: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2064:
+ if ((n_tokens == 0) || (strcmp(tokens[0], "fwd") != 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens < 2'
#754: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2079:
+ if ((n_tokens < 2) ||
+ softnic_parser_read_uint32(&id, tokens[1]))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens < 2'
#773: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2098:
+ if ((n_tokens < 2) ||
+ softnic_parser_read_uint32(&id, tokens[1]))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens == 0'
#793: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2118:
+ if ((n_tokens == 0) || (strcmp(tokens[0], "balance") != 0))
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#809: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2134:
+
+}
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens < 9'
#842: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2167:
+ if ((n_tokens < 9) ||
+ strcmp(tokens[0], "meter") ||
+ softnic_parser_read_uint32(&mtr->meter_profile_id, tokens[1]) ||
+ strcmp(tokens[2], "policer") ||
+ strcmp(tokens[3], "g") ||
+ parse_policer_action(tokens[4], &mtr->policer[e_RTE_METER_GREEN]) ||
+ strcmp(tokens[5], "y") ||
+ parse_policer_action(tokens[6], &mtr->policer[e_RTE_METER_YELLOW]) ||
+ strcmp(tokens[7], "r") ||
+ parse_policer_action(tokens[8], &mtr->policer[e_RTE_METER_RED]))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens == 0'
#862: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2187:
+ if ((n_tokens == 0) || strcmp(tokens[0], "meter"))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens < 10'
#868: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2193:
+ if ((n_tokens < 10) ||
+ strcmp(tokens[0], "tc0") ||
+ (parse_table_action_meter_tc(tokens + 1,
+ n_tokens - 1,
+ &a->mtr.mtr[0]) == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens == 0'
#878: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2203:
+ if ((n_tokens == 0) || strcmp(tokens[0], "tc1")) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens < 30'
#884: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2209:
+ if ((n_tokens < 30) ||
+ (parse_table_action_meter_tc(tokens + 1,
+ n_tokens - 1, &a->mtr.mtr[1]) == 0) ||
+ strcmp(tokens[10], "tc2") ||
+ (parse_table_action_meter_tc(tokens + 11,
+ n_tokens - 11, &a->mtr.mtr[2]) == 0) ||
+ strcmp(tokens[20], "tc3") ||
+ (parse_table_action_meter_tc(tokens + 21,
+ n_tokens - 21, &a->mtr.mtr[3]) == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens < 5'
#907: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2232:
+ if ((n_tokens < 5) ||
+ strcmp(tokens[0], "tm") ||
+ strcmp(tokens[1], "subport") ||
+ softnic_parser_read_uint32(&subport_id, tokens[2]) ||
+ strcmp(tokens[3], "pipe") ||
+ softnic_parser_read_uint32(&pipe_id, tokens[4]))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens == 0'
#926: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2251:
+ if ((n_tokens == 0) || strcmp(tokens[0], "encap"))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens < 3'
#934: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2259:
+ if ((n_tokens < 3) ||
+ softnic_parse_mac_addr(tokens[1], &a->encap.ether.ether.da) ||
+ softnic_parse_mac_addr(tokens[2], &a->encap.ether.ether.sa))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens < 6'
#948: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2273:
+ if ((n_tokens < 6) ||
+ softnic_parse_mac_addr(tokens[1], &a->encap.vlan.ether.da) ||
+ softnic_parse_mac_addr(tokens[2], &a->encap.vlan.ether.sa) ||
+ softnic_parser_read_uint32(&pcp, tokens[3]) ||
+ (pcp > 0x7) ||
+ softnic_parser_read_uint32(&dei, tokens[4]) ||
+ (dei > 0x1) ||
+ softnic_parser_read_uint32(&vid, tokens[5]) ||
+ (vid > 0xFFF))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pcp > 0x7'
#948: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2273:
+ if ((n_tokens < 6) ||
+ softnic_parse_mac_addr(tokens[1], &a->encap.vlan.ether.da) ||
+ softnic_parse_mac_addr(tokens[2], &a->encap.vlan.ether.sa) ||
+ softnic_parser_read_uint32(&pcp, tokens[3]) ||
+ (pcp > 0x7) ||
+ softnic_parser_read_uint32(&dei, tokens[4]) ||
+ (dei > 0x1) ||
+ softnic_parser_read_uint32(&vid, tokens[5]) ||
+ (vid > 0xFFF))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'dei > 0x1'
#948: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2273:
+ if ((n_tokens < 6) ||
+ softnic_parse_mac_addr(tokens[1], &a->encap.vlan.ether.da) ||
+ softnic_parse_mac_addr(tokens[2], &a->encap.vlan.ether.sa) ||
+ softnic_parser_read_uint32(&pcp, tokens[3]) ||
+ (pcp > 0x7) ||
+ softnic_parser_read_uint32(&dei, tokens[4]) ||
+ (dei > 0x1) ||
+ softnic_parser_read_uint32(&vid, tokens[5]) ||
+ (vid > 0xFFF))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vid > 0xFFF'
#948: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2273:
+ if ((n_tokens < 6) ||
+ softnic_parse_mac_addr(tokens[1], &a->encap.vlan.ether.da) ||
+ softnic_parse_mac_addr(tokens[2], &a->encap.vlan.ether.sa) ||
+ softnic_parser_read_uint32(&pcp, tokens[3]) ||
+ (pcp > 0x7) ||
+ softnic_parser_read_uint32(&dei, tokens[4]) ||
+ (dei > 0x1) ||
+ softnic_parser_read_uint32(&vid, tokens[5]) ||
+ (vid > 0xFFF))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens < 9'
#972: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2297:
+ if ((n_tokens < 9) ||
+ softnic_parse_mac_addr(tokens[1], &a->encap.qinq.ether.da) ||
+ softnic_parse_mac_addr(tokens[2], &a->encap.qinq.ether.sa) ||
+ softnic_parser_read_uint32(&svlan_pcp, tokens[3]) ||
+ (svlan_pcp > 0x7) ||
+ softnic_parser_read_uint32(&svlan_dei, tokens[4]) ||
+ (svlan_dei > 0x1) ||
+ softnic_parser_read_uint32(&svlan_vid, tokens[5]) ||
+ (svlan_vid > 0xFFF) ||
+ softnic_parser_read_uint32(&cvlan_pcp, tokens[6]) ||
+ (cvlan_pcp > 0x7) ||
+ softnic_parser_read_uint32(&cvlan_dei, tokens[7]) ||
+ (cvlan_dei > 0x1) ||
+ softnic_parser_read_uint32(&cvlan_vid, tokens[8]) ||
+ (cvlan_vid > 0xFFF))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'svlan_pcp > 0x7'
#972: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2297:
+ if ((n_tokens < 9) ||
+ softnic_parse_mac_addr(tokens[1], &a->encap.qinq.ether.da) ||
+ softnic_parse_mac_addr(tokens[2], &a->encap.qinq.ether.sa) ||
+ softnic_parser_read_uint32(&svlan_pcp, tokens[3]) ||
+ (svlan_pcp > 0x7) ||
+ softnic_parser_read_uint32(&svlan_dei, tokens[4]) ||
+ (svlan_dei > 0x1) ||
+ softnic_parser_read_uint32(&svlan_vid, tokens[5]) ||
+ (svlan_vid > 0xFFF) ||
+ softnic_parser_read_uint32(&cvlan_pcp, tokens[6]) ||
+ (cvlan_pcp > 0x7) ||
+ softnic_parser_read_uint32(&cvlan_dei, tokens[7]) ||
+ (cvlan_dei > 0x1) ||
+ softnic_parser_read_uint32(&cvlan_vid, tokens[8]) ||
+ (cvlan_vid > 0xFFF))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'svlan_dei > 0x1'
#972: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2297:
+ if ((n_tokens < 9) ||
+ softnic_parse_mac_addr(tokens[1], &a->encap.qinq.ether.da) ||
+ softnic_parse_mac_addr(tokens[2], &a->encap.qinq.ether.sa) ||
+ softnic_parser_read_uint32(&svlan_pcp, tokens[3]) ||
+ (svlan_pcp > 0x7) ||
+ softnic_parser_read_uint32(&svlan_dei, tokens[4]) ||
+ (svlan_dei > 0x1) ||
+ softnic_parser_read_uint32(&svlan_vid, tokens[5]) ||
+ (svlan_vid > 0xFFF) ||
+ softnic_parser_read_uint32(&cvlan_pcp, tokens[6]) ||
+ (cvlan_pcp > 0x7) ||
+ softnic_parser_read_uint32(&cvlan_dei, tokens[7]) ||
+ (cvlan_dei > 0x1) ||
+ softnic_parser_read_uint32(&cvlan_vid, tokens[8]) ||
+ (cvlan_vid > 0xFFF))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'svlan_vid > 0xFFF'
#972: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2297:
+ if ((n_tokens < 9) ||
+ softnic_parse_mac_addr(tokens[1], &a->encap.qinq.ether.da) ||
+ softnic_parse_mac_addr(tokens[2], &a->encap.qinq.ether.sa) ||
+ softnic_parser_read_uint32(&svlan_pcp, tokens[3]) ||
+ (svlan_pcp > 0x7) ||
+ softnic_parser_read_uint32(&svlan_dei, tokens[4]) ||
+ (svlan_dei > 0x1) ||
+ softnic_parser_read_uint32(&svlan_vid, tokens[5]) ||
+ (svlan_vid > 0xFFF) ||
+ softnic_parser_read_uint32(&cvlan_pcp, tokens[6]) ||
+ (cvlan_pcp > 0x7) ||
+ softnic_parser_read_uint32(&cvlan_dei, tokens[7]) ||
+ (cvlan_dei > 0x1) ||
+ softnic_parser_read_uint32(&cvlan_vid, tokens[8]) ||
+ (cvlan_vid > 0xFFF))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'cvlan_pcp > 0x7'
#972: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2297:
+ if ((n_tokens < 9) ||
+ softnic_parse_mac_addr(tokens[1], &a->encap.qinq.ether.da) ||
+ softnic_parse_mac_addr(tokens[2], &a->encap.qinq.ether.sa) ||
+ softnic_parser_read_uint32(&svlan_pcp, tokens[3]) ||
+ (svlan_pcp > 0x7) ||
+ softnic_parser_read_uint32(&svlan_dei, tokens[4]) ||
+ (svlan_dei > 0x1) ||
+ softnic_parser_read_uint32(&svlan_vid, tokens[5]) ||
+ (svlan_vid > 0xFFF) ||
+ softnic_parser_read_uint32(&cvlan_pcp, tokens[6]) ||
+ (cvlan_pcp > 0x7) ||
+ softnic_parser_read_uint32(&cvlan_dei, tokens[7]) ||
+ (cvlan_dei > 0x1) ||
+ softnic_parser_read_uint32(&cvlan_vid, tokens[8]) ||
+ (cvlan_vid > 0xFFF))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'cvlan_dei > 0x1'
#972: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2297:
+ if ((n_tokens < 9) ||
+ softnic_parse_mac_addr(tokens[1], &a->encap.qinq.ether.da) ||
+ softnic_parse_mac_addr(tokens[2], &a->encap.qinq.ether.sa) ||
+ softnic_parser_read_uint32(&svlan_pcp, tokens[3]) ||
+ (svlan_pcp > 0x7) ||
+ softnic_parser_read_uint32(&svlan_dei, tokens[4]) ||
+ (svlan_dei > 0x1) ||
+ softnic_parser_read_uint32(&svlan_vid, tokens[5]) ||
+ (svlan_vid > 0xFFF) ||
+ softnic_parser_read_uint32(&cvlan_pcp, tokens[6]) ||
+ (cvlan_pcp > 0x7) ||
+ softnic_parser_read_uint32(&cvlan_dei, tokens[7]) ||
+ (cvlan_dei > 0x1) ||
+ softnic_parser_read_uint32(&cvlan_vid, tokens[8]) ||
+ (cvlan_vid > 0xFFF))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'cvlan_vid > 0xFFF'
#972: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2297:
+ if ((n_tokens < 9) ||
+ softnic_parse_mac_addr(tokens[1], &a->encap.qinq.ether.da) ||
+ softnic_parse_mac_addr(tokens[2], &a->encap.qinq.ether.sa) ||
+ softnic_parser_read_uint32(&svlan_pcp, tokens[3]) ||
+ (svlan_pcp > 0x7) ||
+ softnic_parser_read_uint32(&svlan_dei, tokens[4]) ||
+ (svlan_dei > 0x1) ||
+ softnic_parser_read_uint32(&svlan_vid, tokens[5]) ||
+ (svlan_vid > 0xFFF) ||
+ softnic_parser_read_uint32(&cvlan_pcp, tokens[6]) ||
+ (cvlan_pcp > 0x7) ||
+ softnic_parser_read_uint32(&cvlan_dei, tokens[7]) ||
+ (cvlan_dei > 0x1) ||
+ softnic_parser_read_uint32(&cvlan_vid, tokens[8]) ||
+ (cvlan_vid > 0xFFF))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'label > 0xFFFFF'
#1014: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2339:
+ if (softnic_parse_mac_addr(tokens[2], &a->encap.mpls.ether.da) ||
+ softnic_parse_mac_addr(tokens[3], &a->encap.mpls.ether.sa) ||
+ strcmp(tokens[4], "label0") ||
+ softnic_parser_read_uint32(&label, tokens[5]) ||
+ (label > 0xFFFFF) ||
+ softnic_parser_read_uint32(&tc, tokens[6]) ||
+ (tc > 0x7) ||
+ softnic_parser_read_uint32(&ttl, tokens[7]) ||
+ (ttl > 0x3F))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tc > 0x7'
#1014: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2339:
+ if (softnic_parse_mac_addr(tokens[2], &a->encap.mpls.ether.da) ||
+ softnic_parse_mac_addr(tokens[3], &a->encap.mpls.ether.sa) ||
+ strcmp(tokens[4], "label0") ||
+ softnic_parser_read_uint32(&label, tokens[5]) ||
+ (label > 0xFFFFF) ||
+ softnic_parser_read_uint32(&tc, tokens[6]) ||
+ (tc > 0x7) ||
+ softnic_parser_read_uint32(&ttl, tokens[7]) ||
+ (ttl > 0x3F))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ttl > 0x3F'
#1014: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2339:
+ if (softnic_parse_mac_addr(tokens[2], &a->encap.mpls.ether.da) ||
+ softnic_parse_mac_addr(tokens[3], &a->encap.mpls.ether.sa) ||
+ strcmp(tokens[4], "label0") ||
+ softnic_parser_read_uint32(&label, tokens[5]) ||
+ (label > 0xFFFFF) ||
+ softnic_parser_read_uint32(&tc, tokens[6]) ||
+ (tc > 0x7) ||
+ softnic_parser_read_uint32(&ttl, tokens[7]) ||
+ (ttl > 0x3F))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens == 0'
#1032: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2357:
+ if ((n_tokens == 0) || strcmp(tokens[0], "label1")) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens < 4'
#1039: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2364:
+ if ((n_tokens < 4) ||
+ softnic_parser_read_uint32(&label, tokens[1]) ||
+ (label > 0xFFFFF) ||
+ softnic_parser_read_uint32(&tc, tokens[2]) ||
+ (tc > 0x7) ||
+ softnic_parser_read_uint32(&ttl, tokens[3]) ||
+ (ttl > 0x3F))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'label > 0xFFFFF'
#1039: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2364:
+ if ((n_tokens < 4) ||
+ softnic_parser_read_uint32(&label, tokens[1]) ||
+ (label > 0xFFFFF) ||
+ softnic_parser_read_uint32(&tc, tokens[2]) ||
+ (tc > 0x7) ||
+ softnic_parser_read_uint32(&ttl, tokens[3]) ||
+ (ttl > 0x3F))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tc > 0x7'
#1039: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2364:
+ if ((n_tokens < 4) ||
+ softnic_parser_read_uint32(&label, tokens[1]) ||
+ (label > 0xFFFFF) ||
+ softnic_parser_read_uint32(&tc, tokens[2]) ||
+ (tc > 0x7) ||
+ softnic_parser_read_uint32(&ttl, tokens[3]) ||
+ (ttl > 0x3F))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ttl > 0x3F'
#1039: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2364:
+ if ((n_tokens < 4) ||
+ softnic_parser_read_uint32(&label, tokens[1]) ||
+ (label > 0xFFFFF) ||
+ softnic_parser_read_uint32(&tc, tokens[2]) ||
+ (tc > 0x7) ||
+ softnic_parser_read_uint32(&ttl, tokens[3]) ||
+ (ttl > 0x3F))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens == 0'
#1055: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2380:
+ if ((n_tokens == 0) || strcmp(tokens[0], "label2")) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens < 4'
#1062: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2387:
+ if ((n_tokens < 4) ||
+ softnic_parser_read_uint32(&label, tokens[1]) ||
+ (label > 0xFFFFF) ||
+ softnic_parser_read_uint32(&tc, tokens[2]) ||
+ (tc > 0x7) ||
+ softnic_parser_read_uint32(&ttl, tokens[3]) ||
+ (ttl > 0x3F))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'label > 0xFFFFF'
#1062: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2387:
+ if ((n_tokens < 4) ||
+ softnic_parser_read_uint32(&label, tokens[1]) ||
+ (label > 0xFFFFF) ||
+ softnic_parser_read_uint32(&tc, tokens[2]) ||
+ (tc > 0x7) ||
+ softnic_parser_read_uint32(&ttl, tokens[3]) ||
+ (ttl > 0x3F))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tc > 0x7'
#1062: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2387:
+ if ((n_tokens < 4) ||
+ softnic_parser_read_uint32(&label, tokens[1]) ||
+ (label > 0xFFFFF) ||
+ softnic_parser_read_uint32(&tc, tokens[2]) ||
+ (tc > 0x7) ||
+ softnic_parser_read_uint32(&ttl, tokens[3]) ||
+ (ttl > 0x3F))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ttl > 0x3F'
#1062: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2387:
+ if ((n_tokens < 4) ||
+ softnic_parser_read_uint32(&label, tokens[1]) ||
+ (label > 0xFFFFF) ||
+ softnic_parser_read_uint32(&tc, tokens[2]) ||
+ (tc > 0x7) ||
+ softnic_parser_read_uint32(&ttl, tokens[3]) ||
+ (ttl > 0x3F))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens == 0'
#1078: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2403:
+ if ((n_tokens == 0) || strcmp(tokens[0], "label3")) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens < 4'
#1085: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2410:
+ if ((n_tokens < 4) ||
+ softnic_parser_read_uint32(&label, tokens[1]) ||
+ (label > 0xFFFFF) ||
+ softnic_parser_read_uint32(&tc, tokens[2]) ||
+ (tc > 0x7) ||
+ softnic_parser_read_uint32(&ttl, tokens[3]) ||
+ (ttl > 0x3F))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'label > 0xFFFFF'
#1085: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2410:
+ if ((n_tokens < 4) ||
+ softnic_parser_read_uint32(&label, tokens[1]) ||
+ (label > 0xFFFFF) ||
+ softnic_parser_read_uint32(&tc, tokens[2]) ||
+ (tc > 0x7) ||
+ softnic_parser_read_uint32(&ttl, tokens[3]) ||
+ (ttl > 0x3F))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tc > 0x7'
#1085: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2410:
+ if ((n_tokens < 4) ||
+ softnic_parser_read_uint32(&label, tokens[1]) ||
+ (label > 0xFFFFF) ||
+ softnic_parser_read_uint32(&tc, tokens[2]) ||
+ (tc > 0x7) ||
+ softnic_parser_read_uint32(&ttl, tokens[3]) ||
+ (ttl > 0x3F))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ttl > 0x3F'
#1085: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2410:
+ if ((n_tokens < 4) ||
+ softnic_parser_read_uint32(&label, tokens[1]) ||
+ (label > 0xFFFFF) ||
+ softnic_parser_read_uint32(&tc, tokens[2]) ||
+ (tc > 0x7) ||
+ softnic_parser_read_uint32(&ttl, tokens[3]) ||
+ (ttl > 0x3F))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens < 4'
#1106: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2431:
+ if ((n_tokens < 4) ||
+ softnic_parse_mac_addr(tokens[1], &a->encap.pppoe.ether.da) ||
+ softnic_parse_mac_addr(tokens[2], &a->encap.pppoe.ether.sa) ||
+ softnic_parser_read_uint16(&a->encap.pppoe.pppoe.session_id,
+ tokens[3]))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens < 4'
#1126: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2451:
+ if ((n_tokens < 4) ||
+ strcmp(tokens[0], "nat"))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens < 2'
#1168: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2493:
+ if ((n_tokens < 2) ||
+ strcmp(tokens[0], "ttl"))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens < 1'
#1188: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2513:
+ if ((n_tokens < 1) ||
+ strcmp(tokens[0], "stats"))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens < 1'
#1203: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2528:
+ if ((n_tokens < 1) ||
+ strcmp(tokens[0], "time"))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens < 2'
#1223: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2548:
+ if ((n_tokens < 2) ||
+ strcmp(tokens[0], "action"))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens != 11'
#1473: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2798:
+ if ((n_tokens != 11) && (n_tokens != 12)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens != 12'
#1473: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2798:
+ if ((n_tokens != 11) && (n_tokens != 12)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_rules == 0'
#1647: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2972:
+ if ((softnic_parser_read_uint32(&n_rules, tokens[8]) != 0) ||
+ (n_rules == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'match == NULL'
#1657: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2982:
+ if ((match == NULL) || (action == NULL) || (data == NULL)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'action == NULL'
#1657: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2982:
+ if ((match == NULL) || (action == NULL) || (data == NULL)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'data == NULL'
#1657: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2982:
+ if ((match == NULL) || (action == NULL) || (data == NULL)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 3'
#1982: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3307:
+ if ((n_tokens >= 3) &&
+ (strcmp(tokens[2], "period") == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 5'
#1988: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3313:
+ if ((n_tokens >= 5) &&
+ (strcmp(tokens[2], "port") == 0) &&
+ (strcmp(tokens[3], "in") == 0) &&
+ (strcmp(tokens[4], "bsz") == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 5'
#1996: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3321:
+ if ((n_tokens >= 5) &&
+ (strcmp(tokens[2], "port") == 0) &&
+ (strcmp(tokens[3], "out") == 0) &&
+ (strcmp(tokens[4], "bsz") == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 4'
#2004: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3329:
+ if ((n_tokens >= 4) &&
+ (strcmp(tokens[2], "table") == 0) &&
+ (strcmp(tokens[3], "match") == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 6'
#2011: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3336:
+ if ((n_tokens >= 6) &&
+ (strcmp(tokens[2], "port") == 0) &&
+ (strcmp(tokens[3], "in") == 0) &&
+ (strcmp(tokens[5], "table") == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 6'
#2020: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3345:
+ if ((n_tokens >= 6) &&
+ (strcmp(tokens[2], "port") == 0) &&
+ (strcmp(tokens[3], "in") == 0) &&
+ (strcmp(tokens[5], "enable") == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 6'
#2029: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3354:
+ if ((n_tokens >= 6) &&
+ (strcmp(tokens[2], "port") == 0) &&
+ (strcmp(tokens[3], "in") == 0) &&
+ (strcmp(tokens[5], "disable") == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 7'
#2038: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3363:
+ if ((n_tokens >= 7) &&
+ (strcmp(tokens[2], "table") == 0) &&
+ (strcmp(tokens[4], "rule") == 0) &&
+ (strcmp(tokens[5], "add") == 0) &&
+ (strcmp(tokens[6], "match") == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 8'
#2043: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3368:
+ if ((n_tokens >= 8) &&
+ (strcmp(tokens[7], "default") == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 7'
#2055: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3380:
+ if ((n_tokens >= 7) &&
+ (strcmp(tokens[2], "table") == 0) &&
+ (strcmp(tokens[4], "rule") == 0) &&
+ (strcmp(tokens[5], "add") == 0) &&
+ (strcmp(tokens[6], "bulk") == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 7'
#2065: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3390:
+ if ((n_tokens >= 7) &&
+ (strcmp(tokens[2], "table") == 0) &&
+ (strcmp(tokens[4], "rule") == 0) &&
+ (strcmp(tokens[5], "delete") == 0) &&
+ (strcmp(tokens[6], "match") == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 8'
#2070: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3395:
+ if ((n_tokens >= 8) &&
+ (strcmp(tokens[7], "default") == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 5'
#2084: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3409:
+ if ((n_tokens >= 5) &&
+ (strcmp(tokens[4], "enable") == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 5'
#2091: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3416:
+ if ((n_tokens >= 5) &&
+ (strcmp(tokens[4], "disable") == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'file_name == NULL'
#2112: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3437:
+ if ((file_name == NULL) ||
+ (strlen(file_name) == 0) ||
+ (msg_in_len_max == 0) ||
+ (msg_out_len_max == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'msg_in_len_max == 0'
#2112: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3437:
+ if ((file_name == NULL) ||
+ (strlen(file_name) == 0) ||
+ (msg_in_len_max == 0) ||
+ (msg_out_len_max == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'msg_out_len_max == 0'
#2112: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3437:
+ if ((file_name == NULL) ||
+ (strlen(file_name) == 0) ||
+ (msg_in_len_max == 0) ||
+ (msg_out_len_max == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'msg_in == NULL'
#2120: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3445:
+ if ((msg_in == NULL) ||
+ (msg_out == NULL)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'msg_out == NULL'
#2120: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3445:
+ if ((msg_in == NULL) ||
+ (msg_out == NULL)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'file_name == NULL'
#2175: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3500:
+ if ((file_name == NULL) ||
+ (strlen(file_name) == 0) ||
+ (line_len_max == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'line_len_max == 0'
#2175: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3500:
+ if ((file_name == NULL) ||
+ (strlen(file_name) == 0) ||
+ (line_len_max == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'match == NULL'
#2417: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:694:
+ if ((match == NULL) ||
+ (p == NULL) ||
+ (table_id >= p->n_tables))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#2417: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:694:
+ if ((match == NULL) ||
+ (p == NULL) ||
+ (table_id >= p->n_tables))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'table_id >= p->n_tables'
#2417: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:694:
+ if ((match == NULL) ||
+ (p == NULL) ||
+ (table_id >= p->n_tables))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 't->ip_version == 0'
#2432: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:709:
+ if ((r->ip_version && (t->ip_version == 0)) ||
+ ((r->ip_version == 0) && t->ip_version))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'r->ip_version == 0'
#2432: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:709:
+ if ((r->ip_version && (t->ip_version == 0)) ||
+ ((r->ip_version == 0) && t->ip_version))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'r->sa_depth > 32'
#2437: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:714:
+ if ((r->sa_depth > 32) ||
+ (r->da_depth > 32))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'r->da_depth > 32'
#2437: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:714:
+ if ((r->sa_depth > 32) ||
+ (r->da_depth > 32))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'r->sa_depth > 128'
#2441: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:718:
+ if ((r->sa_depth > 128) ||
+ (r->da_depth > 128))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'r->da_depth > 128'
#2441: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:718:
+ if ((r->sa_depth > 128) ||
+ (r->da_depth > 128))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 't->key_size != 4'
#2459: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:736:
+ if ((r->ip_version && (t->key_size != 4)) ||
+ ((r->ip_version == 0) && (t->key_size != 16)))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'r->ip_version == 0'
#2459: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:736:
+ if ((r->ip_version && (t->key_size != 4)) ||
+ ((r->ip_version == 0) && (t->key_size != 16)))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 't->key_size != 16'
#2459: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:736:
+ if ((r->ip_version && (t->key_size != 4)) ||
+ ((r->ip_version == 0) && (t->key_size != 16)))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'action == NULL'
#2488: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:765:
+ if ((action == NULL) ||
+ (p == NULL) ||
+ (table_id >= p->n_tables))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#2488: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:765:
+ if ((action == NULL) ||
+ (p == NULL) ||
+ (table_id >= p->n_tables))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'table_id >= p->n_tables'
#2488: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:765:
+ if ((action == NULL) ||
+ (p == NULL) ||
+ (table_id >= p->n_tables))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'action->fwd.action == RTE_PIPELINE_ACTION_PORT'
#2498: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:775:
+ if ((action->fwd.action == RTE_PIPELINE_ACTION_PORT) &&
+ (action->fwd.id >= p->n_ports_out))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'action->fwd.id >= p->n_ports_out'
#2498: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:775:
+ if ((action->fwd.action == RTE_PIPELINE_ACTION_PORT) &&
+ (action->fwd.id >= p->n_ports_out))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'action->fwd.action == RTE_PIPELINE_ACTION_TABLE'
#2502: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:779:
+ if ((action->fwd.action == RTE_PIPELINE_ACTION_TABLE) &&
+ (action->fwd.id >= p->n_tables))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'action->fwd.id >= p->n_tables'
#2502: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:779:
+ if ((action->fwd.action == RTE_PIPELINE_ACTION_TABLE) &&
+ (action->fwd.id >= p->n_tables))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'subport_id >= n_subports_per_port'
#2523: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:800:
+ if ((subport_id >= n_subports_per_port) ||
+ (pipe_id >= n_pipes_per_subport))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipe_id >= n_pipes_per_subport'
#2523: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:800:
+ if ((subport_id >= n_subports_per_port) ||
+ (pipe_id >= n_pipes_per_subport))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ip_version0 == 0'
#2540: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:817:
+ if ((ip_version1 && (ip_version0 == 0)) ||
+ ((ip_version1 == 0) && ip_version0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ip_version1 == 0'
#2540: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:817:
+ if ((ip_version1 && (ip_version0 == 0)) ||
+ ((ip_version1 == 0) && ip_version0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'action == NULL'
#2553: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:830:
+ if ((action == NULL) ||
+ (action->action_mask != (1LLU << RTE_TABLE_ACTION_FWD)) ||
+ (p == NULL) ||
+ (table_id >= p->n_tables))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#2553: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:830:
+ if ((action == NULL) ||
+ (action->action_mask != (1LLU << RTE_TABLE_ACTION_FWD)) ||
+ (p == NULL) ||
+ (table_id >= p->n_tables))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'table_id >= p->n_tables'
#2553: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:830:
+ if ((action == NULL) ||
+ (action->action_mask != (1LLU << RTE_TABLE_ACTION_FWD)) ||
+ (p == NULL) ||
+ (table_id >= p->n_tables))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'action->fwd.action == RTE_PIPELINE_ACTION_PORT'
#2560: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:837:
+ if ((action->fwd.action == RTE_PIPELINE_ACTION_PORT) &&
+ (action->fwd.id >= p->n_ports_out))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'action->fwd.id >= p->n_ports_out'
#2560: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:837:
+ if ((action->fwd.action == RTE_PIPELINE_ACTION_PORT) &&
+ (action->fwd.id >= p->n_ports_out))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'action->fwd.action == RTE_PIPELINE_ACTION_TABLE'
#2564: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:841:
+ if ((action->fwd.action == RTE_PIPELINE_ACTION_TABLE) &&
+ (action->fwd.id >= p->n_tables))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'action->fwd.id >= p->n_tables'
#2564: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:841:
+ if ((action->fwd.action == RTE_PIPELINE_ACTION_TABLE) &&
+ (action->fwd.id >= p->n_tables))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline_name == NULL'
#2586: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:863:
+ if ((pipeline_name == NULL) ||
+ (match == NULL) ||
+ (action == NULL) ||
+ (data == NULL))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'match == NULL'
#2586: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:863:
+ if ((pipeline_name == NULL) ||
+ (match == NULL) ||
+ (action == NULL) ||
+ (data == NULL))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'action == NULL'
#2586: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:863:
+ if ((pipeline_name == NULL) ||
+ (match == NULL) ||
+ (action == NULL) ||
+ (data == NULL))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'data == NULL'
#2586: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:863:
+ if ((pipeline_name == NULL) ||
+ (match == NULL) ||
+ (action == NULL) ||
+ (data == NULL))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#2593: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:870:
+ if ((p == NULL) ||
+ (p->enabled == 0) ||
+ (table_id >= p->n_tables) ||
+ match_check(match, p, table_id) ||
+ action_check(action, p, table_id))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->enabled == 0'
#2593: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:870:
+ if ((p == NULL) ||
+ (p->enabled == 0) ||
+ (table_id >= p->n_tables) ||
+ match_check(match, p, table_id) ||
+ action_check(action, p, table_id))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'table_id >= p->n_tables'
#2593: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:870:
+ if ((p == NULL) ||
+ (p->enabled == 0) ||
+ (table_id >= p->n_tables) ||
+ match_check(match, p, table_id) ||
+ action_check(action, p, table_id))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline_name == NULL'
#2640: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:917:
+ if ((pipeline_name == NULL) ||
+ (action == NULL) ||
+ (data == NULL))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'action == NULL'
#2640: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:917:
+ if ((pipeline_name == NULL) ||
+ (action == NULL) ||
+ (data == NULL))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'data == NULL'
#2640: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:917:
+ if ((pipeline_name == NULL) ||
+ (action == NULL) ||
+ (data == NULL))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#2646: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:923:
+ if ((p == NULL) ||
+ (p->enabled == 0) ||
+ (table_id >= p->n_tables) ||
+ action_default_check(action, p, table_id))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->enabled == 0'
#2646: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:923:
+ if ((p == NULL) ||
+ (p->enabled == 0) ||
+ (table_id >= p->n_tables) ||
+ action_default_check(action, p, table_id))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'table_id >= p->n_tables'
#2646: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:923:
+ if ((p == NULL) ||
+ (p->enabled == 0) ||
+ (table_id >= p->n_tables) ||
+ action_default_check(action, p, table_id))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline_name == NULL'
#2694: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:971:
+ if ((pipeline_name == NULL) ||
+ (match == NULL) ||
+ (action == NULL) ||
+ (data == NULL) ||
+ (n_rules == NULL) ||
+ (*n_rules == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'match == NULL'
#2694: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:971:
+ if ((pipeline_name == NULL) ||
+ (match == NULL) ||
+ (action == NULL) ||
+ (data == NULL) ||
+ (n_rules == NULL) ||
+ (*n_rules == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'action == NULL'
#2694: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:971:
+ if ((pipeline_name == NULL) ||
+ (match == NULL) ||
+ (action == NULL) ||
+ (data == NULL) ||
+ (n_rules == NULL) ||
+ (*n_rules == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'data == NULL'
#2694: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:971:
+ if ((pipeline_name == NULL) ||
+ (match == NULL) ||
+ (action == NULL) ||
+ (data == NULL) ||
+ (n_rules == NULL) ||
+ (*n_rules == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_rules == NULL'
#2694: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:971:
+ if ((pipeline_name == NULL) ||
+ (match == NULL) ||
+ (action == NULL) ||
+ (data == NULL) ||
+ (n_rules == NULL) ||
+ (*n_rules == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#2703: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:980:
+ if ((p == NULL) ||
+ (p->enabled == 0) ||
+ (table_id >= p->n_tables))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->enabled == 0'
#2703: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:980:
+ if ((p == NULL) ||
+ (p->enabled == 0) ||
+ (table_id >= p->n_tables))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'table_id >= p->n_tables'
#2703: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:980:
+ if ((p == NULL) ||
+ (p->enabled == 0) ||
+ (table_id >= p->n_tables))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline_name == NULL'
#2756: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1033:
+ if ((pipeline_name == NULL) ||
+ (match == NULL))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'match == NULL'
#2756: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1033:
+ if ((pipeline_name == NULL) ||
+ (match == NULL))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#2761: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1038:
+ if ((p == NULL) ||
+ (p->enabled == 0) ||
+ (table_id >= p->n_tables) ||
+ match_check(match, p, table_id))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->enabled == 0'
#2761: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1038:
+ if ((p == NULL) ||
+ (p->enabled == 0) ||
+ (table_id >= p->n_tables) ||
+ match_check(match, p, table_id))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'table_id >= p->n_tables'
#2761: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1038:
+ if ((p == NULL) ||
+ (p->enabled == 0) ||
+ (table_id >= p->n_tables) ||
+ match_check(match, p, table_id))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#2806: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1083:
+ if ((p == NULL) ||
+ (p->enabled == 0) ||
+ (table_id >= p->n_tables))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->enabled == 0'
#2806: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1083:
+ if ((p == NULL) ||
+ (p->enabled == 0) ||
+ (table_id >= p->n_tables))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'table_id >= p->n_tables'
#2806: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1083:
+ if ((p == NULL) ||
+ (p->enabled == 0) ||
+ (table_id >= p->n_tables))
CHECK:SPACING: No space is necessary after a cast
#2934: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1257:
+ (int32_t) mh->match.acl.priority;
CHECK:SPACING: No space is necessary after a cast
#2964: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1287:
+ (uint32_t *) mh->match.acl.ipv6.sa;
CHECK:SPACING: No space is necessary after a cast
#2966: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1289:
+ (uint32_t *) mh->match.acl.ipv6.da;
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#2970: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1293:
+ status = match_convert_ipv6_depth(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#2976: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1299:
+ status = match_convert_ipv6_depth(
CHECK:SPACING: No space is necessary after a cast
#3024: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1347:
+ (int32_t) mh->match.acl.priority;
CHECK:SPACING: No space is necessary after a cast
#3027: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1350:
+ (uint32_t *) mh->match.acl.ipv6.sa;
CHECK:SPACING: No space is necessary after a cast
#3029: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1352:
+ (uint32_t *) mh->match.acl.ipv6.da;
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#3033: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1356:
+ status = match_convert_ipv6_depth(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#3039: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1362:
+ status = match_convert_ipv6_depth(
CHECK:SPACING: No space is necessary after a cast
#3126: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1449:
+ struct pipeline_msg_rsp *rsp = (struct pipeline_msg_rsp *) req;
CHECK:SPACING: No space is necessary after a cast
#3136: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1459:
+ data_in = (struct rte_pipeline_table_entry *) p->buffer;
CHECK:SPACING: No space is necessary after a cast
#3275: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1598:
+ struct pipeline_msg_rsp *rsp = (struct pipeline_msg_rsp *) req;
CHECK:SPACING: No space is necessary after a cast
#3283: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1606:
+ data_in = (struct rte_pipeline_table_entry *) p->buffer;
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#3312: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1635:
+{
+
CHECK:SPACING: No space is necessary after a cast
#3313: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1636:
+ struct pipeline_msg_rsp *rsp = (struct pipeline_msg_rsp *) req;
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'match_ll == NULL'
#3339: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1662:
+ if ((match_ll == NULL) ||
+ (action_ll == NULL) ||
+ (match_ll_ptr == NULL) ||
+ (action_ll_ptr == NULL) ||
+ (found == NULL))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'action_ll == NULL'
#3339: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1662:
+ if ((match_ll == NULL) ||
+ (action_ll == NULL) ||
+ (match_ll_ptr == NULL) ||
+ (action_ll_ptr == NULL) ||
+ (found == NULL))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'match_ll_ptr == NULL'
#3339: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1662:
+ if ((match_ll == NULL) ||
+ (action_ll == NULL) ||
+ (match_ll_ptr == NULL) ||
+ (action_ll_ptr == NULL) ||
+ (found == NULL))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'action_ll_ptr == NULL'
#3339: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1662:
+ if ((match_ll == NULL) ||
+ (action_ll == NULL) ||
+ (match_ll_ptr == NULL) ||
+ (action_ll_ptr == NULL) ||
+ (found == NULL))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'found == NULL'
#3339: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1662:
+ if ((match_ll == NULL) ||
+ (action_ll == NULL) ||
+ (match_ll_ptr == NULL) ||
+ (action_ll_ptr == NULL) ||
+ (found == NULL))
WARNING:LONG_LINE: line over 90 characters
#3349: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1672:
+ (struct rte_pipeline_table_entry *)&action_ll[i * TABLE_RULE_ACTION_SIZE_MAX];
CHECK:SPACING: No space is necessary after a cast
#3511: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1834:
+ struct pipeline_msg_rsp *rsp = (struct pipeline_msg_rsp *) req;
CHECK:SPACING: No space is necessary after a cast
#3535: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1858:
+ struct pipeline_msg_rsp *rsp = (struct pipeline_msg_rsp *) req;
total: 0 errors, 1 warnings, 164 checks, 3530 lines checked
parent reply other threads:[~2018-06-15 16:54 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20180615165224.25004-17-jasvinder.singh@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180615165445.BC4FC1C0DA@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).