From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jasvinder Singh <jasvinder.singh@intel.com>
Subject: [dpdk-test-report] |WARNING| pw41213 [v2] [PATCH 19/22] net/softnic: add cli for ttl action
Date: Fri, 15 Jun 2018 18:54:49 +0200 (CEST) [thread overview]
Message-ID: <20180615165449.F073C1C02D@dpdk.org> (raw)
In-Reply-To: <20180615165224.25004-20-jasvinder.singh@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/41213
_coding style issues_
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 7'
#54: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:4123:
+ if ((n_tokens >= 7) &&
+ (strcmp(tokens[2], "table") == 0) &&
+ (strcmp(tokens[4], "rule") == 0) &&
+ (strcmp(tokens[5], "read") == 0) &&
+ (strcmp(tokens[6], "ttl") == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline_name == NULL'
#154: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1611:
+ if ((pipeline_name == NULL) ||
+ (data == NULL) ||
+ (stats == NULL))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'data == NULL'
#154: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1611:
+ if ((pipeline_name == NULL) ||
+ (data == NULL) ||
+ (stats == NULL))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'stats == NULL'
#154: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1611:
+ if ((pipeline_name == NULL) ||
+ (data == NULL) ||
+ (stats == NULL))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#160: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1617:
+ if ((p == NULL) ||
+ (p->enabled == 0) ||
+ (table_id >= p->n_tables))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->enabled == 0'
#160: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1617:
+ if ((p == NULL) ||
+ (p->enabled == 0) ||
+ (table_id >= p->n_tables))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'table_id >= p->n_tables'
#160: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1617:
+ if ((p == NULL) ||
+ (p->enabled == 0) ||
+ (table_id >= p->n_tables))
CHECK:SPACING: No space is necessary after a cast
#203: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:2548:
+ struct pipeline_msg_rsp *rsp = (struct pipeline_msg_rsp *) req;
total: 0 errors, 0 warnings, 8 checks, 183 lines checked
parent reply other threads:[~2018-06-15 16:54 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20180615165224.25004-20-jasvinder.singh@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180615165449.F073C1C02D@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).