From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id F073C1C02D; Fri, 15 Jun 2018 18:54:49 +0200 (CEST)
In-Reply-To: <20180615165224.25004-20-jasvinder.singh@intel.com>
References: <20180615165224.25004-20-jasvinder.singh@intel.com>
To: test-report@dpdk.org
Cc: Jasvinder Singh <jasvinder.singh@intel.com>
Message-Id: <20180615165449.F073C1C02D@dpdk.org>
Date: Fri, 15 Jun 2018 18:54:49 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw41213 [v2] [PATCH 19/22]
	net/softnic: add cli for ttl action
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Jun 2018 16:54:50 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/41213

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 7'
#54: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:4123:
+		if ((n_tokens >= 7) &&
+			(strcmp(tokens[2], "table") == 0) &&
+			(strcmp(tokens[4], "rule") == 0) &&
+			(strcmp(tokens[5], "read") == 0) &&
+			(strcmp(tokens[6], "ttl") == 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline_name == NULL'
#154: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1611:
+	if ((pipeline_name == NULL) ||
+		(data == NULL) ||
+		(stats == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'data == NULL'
#154: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1611:
+	if ((pipeline_name == NULL) ||
+		(data == NULL) ||
+		(stats == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'stats == NULL'
#154: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1611:
+	if ((pipeline_name == NULL) ||
+		(data == NULL) ||
+		(stats == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#160: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1617:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(table_id >= p->n_tables))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->enabled == 0'
#160: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1617:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(table_id >= p->n_tables))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'table_id >= p->n_tables'
#160: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1617:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(table_id >= p->n_tables))

CHECK:SPACING: No space is necessary after a cast
#203: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:2548:
+	struct pipeline_msg_rsp *rsp = (struct pipeline_msg_rsp *) req;

total: 0 errors, 0 warnings, 8 checks, 183 lines checked