From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jasvinder Singh <jasvinder.singh@intel.com>
Subject: [dpdk-test-report] |WARNING| pw41216 [v2] [PATCH 22/22] app/testpmd: rework softnic forward mode
Date: Fri, 15 Jun 2018 18:58:12 +0200 (CEST) [thread overview]
Message-ID: <20180615165812.EC34C1BEEE@dpdk.org> (raw)
In-Reply-To: <20180615165224.25004-23-jasvinder.singh@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/41216
_coding style issues_
WARNING:TYPO_SPELLING: 'firware' may be misspelled - perhaps 'firmware'?
#22:
$ ./testpmd -c 0xc -n 4 --vdev 'net_softnic0,firware=script.cli'
ERROR:SPACING: spaces required around that '=' (ctx:WxV)
#163: FILE: app/test-pmd/config.c:2348:
+ softnic_enable =1;
^
ERROR:SPACING: space required before the open parenthesis '('
#206: FILE: app/test-pmd/config.c:2392:
+ if(strcmp(cur_fwd_eng->fwd_mode_name, "softnic") == 0) {
ERROR:SPACING: space required before the open parenthesis '('
#435: FILE: app/test-pmd/softnicfwd.c:150:
+ for(;;) {
WARNING:RETURN_VOID: void function return statements are not generally useful
#443: FILE: app/test-pmd/softnicfwd.c:158:
+ return;
+}
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#447: FILE: app/test-pmd/softnicfwd.c:162:
+static int
+softnic_begin(void *arg __rte_unused) {
ERROR:SPACING: space required before the open parenthesis '('
#454: FILE: app/test-pmd/softnicfwd.c:169:
+ } while(!softnic_fwd_lcore->stopped);
WARNING:RETURN_VOID: void function return statements are not generally useful
#711: FILE: app/test-pmd/softnicfwd.c:683:
+ return;
+}
WARNING:MISSING_EOF_NEWLINE: adding a line without newline at end of file
#720: FILE: app/test-pmd/softnicfwd.c:690:
+};
total: 5 errors, 4 warnings, 768 lines checked
parent reply other threads:[~2018-06-15 16:58 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20180615165224.25004-23-jasvinder.singh@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180615165812.EC34C1BEEE@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).