From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id CAB9C1BEA9; Thu,  5 Jul 2018 17:50:21 +0200 (CEST)
In-Reply-To: <20180705154754.147420-13-jasvinder.singh@intel.com>
References: <20180705154754.147420-13-jasvinder.singh@intel.com>
To: test-report@dpdk.org
Cc: Jasvinder Singh <jasvinder.singh@intel.com>
Message-Id: <20180705155021.CAB9C1BEA9@dpdk.org>
Date: Thu,  5 Jul 2018 17:50:21 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw42377 [v4,
	12/23] net/softnic: add cli interface
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Jul 2018 15:50:22 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/42377

_coding style issues_


CHECK:BRACES: braces {} should be used on all arms of this statement
#425: FILE: drivers/net/softnic/parser.c:376:
+		if (pch != NULL) {
[...]
+		} else if (ch == '.' && saw_digit) {
[...]
+		} else
[...]

CHECK:BRACES: Unbalanced braces around else statement
#441: FILE: drivers/net/softnic/parser.c:392:
+		} else

CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#483: FILE: drivers/net/softnic/parser.c:434:
+	saw_xdigit = count_xdigit = 0;

WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(o)
#577: FILE: drivers/net/softnic/parser.c:528:
+	} while (++i != sizeof(o) / sizeof(o[0]) && end[0] != 0);

CHECK:BRACES: braces {} should be used on all arms of this statement
#584: FILE: drivers/net/softnic/parser.c:535:
+	if (i == ETHER_ADDR_LEN) {
[...]
+	} else if (i == ETHER_ADDR_LEN / 2) {
[...]
+	} else
[...]

CHECK:BRACES: Unbalanced braces around else statement
#599: FILE: drivers/net/softnic/parser.c:550:
+	} else

total: 0 errors, 1 warnings, 5 checks, 897 lines checked