From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id A90F31B585; Thu,  5 Jul 2018 17:50:28 +0200 (CEST)
In-Reply-To: <20180705154754.147420-16-jasvinder.singh@intel.com>
References: <20180705154754.147420-16-jasvinder.singh@intel.com>
To: test-report@dpdk.org
Cc: Jasvinder Singh <jasvinder.singh@intel.com>
Message-Id: <20180705155028.A90F31B585@dpdk.org>
Date: Thu,  5 Jul 2018 17:50:28 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw42380 [v4,
	15/23] net/softnic: add cli to enable and disable pipeline
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Jul 2018 15:50:29 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/42380

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 5'
#130: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1791:
+		if ((n_tokens >= 5) &&
+			(strcmp(tokens[4], "enable") == 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 5'
#137: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1798:
+		if ((n_tokens >= 5) &&
+			(strcmp(tokens[4], "disable") == 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'thread_id >= RTE_MAX_LCORE'
#263: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:182:
+	if ((thread_id >= RTE_MAX_LCORE) ||
+		(p == NULL) ||
+		(p->n_ports_in == 0) ||
+		(p->n_ports_out == 0) ||
+		(p->n_tables == 0))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#263: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:182:
+	if ((thread_id >= RTE_MAX_LCORE) ||
+		(p == NULL) ||
+		(p->n_ports_in == 0) ||
+		(p->n_ports_out == 0) ||
+		(p->n_tables == 0))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->n_ports_in == 0'
#263: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:182:
+	if ((thread_id >= RTE_MAX_LCORE) ||
+		(p == NULL) ||
+		(p->n_ports_in == 0) ||
+		(p->n_ports_out == 0) ||
+		(p->n_tables == 0))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->n_ports_out == 0'
#263: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:182:
+	if ((thread_id >= RTE_MAX_LCORE) ||
+		(p == NULL) ||
+		(p->n_ports_in == 0) ||
+		(p->n_ports_out == 0) ||
+		(p->n_tables == 0))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->n_tables == 0'
#263: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:182:
+	if ((thread_id >= RTE_MAX_LCORE) ||
+		(p == NULL) ||
+		(p->n_ports_in == 0) ||
+		(p->n_ports_out == 0) ||
+		(p->n_tables == 0))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 't->enabled == 0'
#271: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:190:
+	if ((t->enabled == 0) ||
+		p->enabled)

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'thread_id >= RTE_MAX_LCORE'
#356: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:275:
+	if ((thread_id >= RTE_MAX_LCORE) ||
+		(p == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#356: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:275:
+	if ((thread_id >= RTE_MAX_LCORE) ||
+		(p == NULL))

total: 0 errors, 0 warnings, 10 checks, 485 lines checked