From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jasvinder Singh <jasvinder.singh@intel.com>
Subject: [dpdk-test-report] |WARNING| pw42381 [v4, 16/23] net/softnic: add cli for pipeline table entries
Date: Thu, 5 Jul 2018 17:50:34 +0200 (CEST) [thread overview]
Message-ID: <20180705155034.841141B8BF@dpdk.org> (raw)
In-Reply-To: <20180705154754.147420-17-jasvinder.singh@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/42381
_coding style issues_
WARNING:LONG_LINE: line over 90 characters
#2056: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3392:
+ cmd_softnic_softnic_pipeline_table_rule_add_default(softnic, tokens,
WARNING:LONG_LINE: line over 90 characters
#2083: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3419:
+ cmd_softnic_softnic_pipeline_table_rule_delete_default(softnic, tokens,
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 't->ip_version == 0'
#2443: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:709:
+ if ((r->ip_version && (t->ip_version == 0)) ||
+ ((r->ip_version == 0) && t->ip_version))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'r->ip_version == 0'
#2443: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:709:
+ if ((r->ip_version && (t->ip_version == 0)) ||
+ ((r->ip_version == 0) && t->ip_version))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 't->key_size != 4'
#2470: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:736:
+ if ((r->ip_version && (t->key_size != 4)) ||
+ ((r->ip_version == 0) && (t->key_size != 16)))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'r->ip_version == 0'
#2470: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:736:
+ if ((r->ip_version && (t->key_size != 4)) ||
+ ((r->ip_version == 0) && (t->key_size != 16)))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 't->key_size != 16'
#2470: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:736:
+ if ((r->ip_version && (t->key_size != 4)) ||
+ ((r->ip_version == 0) && (t->key_size != 16)))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ip_version0 == 0'
#2551: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:817:
+ if ((ip_version1 && (ip_version0 == 0)) ||
+ ((ip_version1 == 0) && ip_version0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ip_version1 == 0'
#2551: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:817:
+ if ((ip_version1 && (ip_version0 == 0)) ||
+ ((ip_version1 == 0) && ip_version0))
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#2986: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1298:
+ status = match_convert_ipv6_depth(
WARNING:LONG_LINE: line over 90 characters
#3356: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1668:
+ (struct rte_pipeline_table_entry *)&action_ll[i * TABLE_RULE_ACTION_SIZE_MAX];
total: 0 errors, 3 warnings, 8 checks, 3536 lines checked
parent reply other threads:[~2018-07-05 15:50 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20180705154754.147420-17-jasvinder.singh@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180705155034.841141B8BF@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).