From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id C3F783237; Fri, 13 Jul 2018 19:07:14 +0200 (CEST)
In-Reply-To: <20180713170644.9306-4-stephen@networkplumber.org>
References: <20180713170644.9306-4-stephen@networkplumber.org>
To: test-report@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Message-Id: <20180713170714.C3F783237@dpdk.org>
Date: Fri, 13 Jul 2018 19:07:14 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw43079 [v12,
	3/4] net/netvsc: add hyper-v netvsc network device
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Jul 2018 17:07:14 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/43079

_coding style issues_


CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#267: FILE: drivers/net/netvsc/hn_ethdev.c:92:
+			eth_dev->data->dev_private
+				= rte_zmalloc_socket(name, private_data_size,

WARNING:LONG_LINE: line over 90 characters
#268: FILE: drivers/net/netvsc/hn_ethdev.c:93:
+						     RTE_CACHE_LINE_SIZE, dev->device.numa_node);

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#363: FILE: drivers/net/netvsc/hn_ethdev.c:188:
+	dev_info->flow_type_rss_offloads
+		= ETH_RSS_IPV4 | ETH_RSS_IPV6 | ETH_RSS_TCP | ETH_RSS_UDP;

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#467: FILE: drivers/net/netvsc/hn_ethdev.c:292:
+	const struct rte_eth_rss_conf *rss_conf
+		= &dev_conf->rx_adv_conf.rss_conf;

CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#477: FILE: drivers/net/netvsc/hn_ethdev.c:302:
+			    "unsupported TX offload: %#" PRIx64,

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#638: FILE: drivers/net/netvsc/hn_ethdev.c:463:
+	const unsigned int nstats
+		= dev->data->nb_tx_queues * RTE_DIM(hn_stat_strings)

CHECK:CAMELCASE: Avoid CamelCase: <PRIu64>
#1457: FILE: drivers/net/netvsc/hn_nvs.c:474:
+	PMD_RX_LOG(DEBUG, "ack RX id %" PRIu64, tid);

CHECK:CAMELCASE: Avoid CamelCase: <PRIx32>
#2494: FILE: drivers/net/netvsc/hn_rndis.c:724:
+		PMD_DRV_LOG(ERR, "exec RNDIS set %#" PRIx32 " failed",

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#3357: FILE: drivers/net/netvsc/hn_rxtx.c:442:
+		struct rte_eth_dev *dev
+			= &rte_eth_devices[rxq->port_id];

total: 0 errors, 1 warnings, 5072 lines checked