From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id B48AF4CA6; Wed, 25 Jul 2018 19:10:30 +0200 (CEST)
In-Reply-To: <20180725171007.94198-5-jasvinder.singh@intel.com>
References: <20180725171007.94198-5-jasvinder.singh@intel.com>
To: test-report@dpdk.org
Cc: Jasvinder Singh <jasvinder.singh@intel.com>
Message-Id: <20180725171030.B48AF4CA6@dpdk.org>
Date: Wed, 25 Jul 2018 19:10:30 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw43374 [4/6] net/softnic: add CLI
	command for tmgr node addition
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Jul 2018 17:10:31 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/43374

_coding style issues_


CHECK:BRACES: braces {} should be used on all arms of this statement
#86: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:392:
+	if (strcmp(tokens[5], "none") == 0)
[...]
+	else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#88: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:394:
+	else {

WARNING:LONG_LINE: line over 90 characters
#129: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:435:
+			if (softnic_parser_read_uint32(&np.shaper_profile_id, tokens[2]) != 0) {

WARNING:LONG_LINE: line over 90 characters
#167: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:473:
+		if (softnic_parser_read_uint32(&np.nonleaf.n_sp_priorities, tokens[2]) != 0) {

total: 0 errors, 2 warnings, 2 checks, 183 lines checked