automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jasvinder Singh <jasvinder.singh@intel.com>
Subject: [dpdk-test-report] |WARNING| pw43376 [6/6] net/softnic: add CLI command for default tmgr hierarchy
Date: Wed, 25 Jul 2018 19:10:33 +0200 (CEST)	[thread overview]
Message-ID: <20180725171033.348BB4CA6@dpdk.org> (raw)
In-Reply-To: <20180725171007.94198-7-jasvinder.singh@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/43376

_coding style issues_


CHECK:BRACES: braces {} should be used on all arms of this statement
#442: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:912:
+	if (strcmp(tokens[25], "none") == 0)
[...]
+	else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#444: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:914:
+	else {

WARNING:LONG_LINE: line over 90 characters
#445: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:915:
+		if (softnic_parser_read_uint32(&p.shared_shaper_id.tc[0], tokens[25]) != 0) {

CHECK:BRACES: braces {} should be used on all arms of this statement
#458: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:928:
+	if (strcmp(tokens[27], "none") == 0)
[...]
+	else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#460: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:930:
+	else {

WARNING:LONG_LINE: line over 90 characters
#461: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:931:
+		if (softnic_parser_read_uint32(&p.shared_shaper_id.tc[1], tokens[27]) != 0) {

CHECK:BRACES: braces {} should be used on all arms of this statement
#474: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:944:
+	if (strcmp(tokens[29], "none") == 0)
[...]
+	else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#476: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:946:
+	else {

WARNING:LONG_LINE: line over 90 characters
#477: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:947:
+		if (softnic_parser_read_uint32(&p.shared_shaper_id.tc[2], tokens[29]) != 0) {

CHECK:BRACES: braces {} should be used on all arms of this statement
#490: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:960:
+	if (strcmp(tokens[31], "none") == 0)
[...]
+	else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#492: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:962:
+	else {

WARNING:LONG_LINE: line over 90 characters
#493: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:963:
+		if (softnic_parser_read_uint32(&p.shared_shaper_id.tc[3], tokens[31]) != 0) {

WARNING:LONG_LINE: line over 90 characters
#536: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:4863:
+			cmd_tmgr_hierarchy_default(softnic, tokens, n_tokens, out, out_size);

total: 0 errors, 5 warnings, 8 checks, 510 lines checked

           reply	other threads:[~2018-07-25 17:10 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20180725171007.94198-7-jasvinder.singh@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180725171033.348BB4CA6@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=jasvinder.singh@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).