From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 348BB4CA6; Wed, 25 Jul 2018 19:10:33 +0200 (CEST)
In-Reply-To: <20180725171007.94198-7-jasvinder.singh@intel.com>
References: <20180725171007.94198-7-jasvinder.singh@intel.com>
To: test-report@dpdk.org
Cc: Jasvinder Singh <jasvinder.singh@intel.com>
Message-Id: <20180725171033.348BB4CA6@dpdk.org>
Date: Wed, 25 Jul 2018 19:10:33 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw43376 [6/6] net/softnic: add CLI
	command for default tmgr hierarchy
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Jul 2018 17:10:33 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/43376

_coding style issues_


CHECK:BRACES: braces {} should be used on all arms of this statement
#442: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:912:
+	if (strcmp(tokens[25], "none") == 0)
[...]
+	else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#444: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:914:
+	else {

WARNING:LONG_LINE: line over 90 characters
#445: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:915:
+		if (softnic_parser_read_uint32(&p.shared_shaper_id.tc[0], tokens[25]) != 0) {

CHECK:BRACES: braces {} should be used on all arms of this statement
#458: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:928:
+	if (strcmp(tokens[27], "none") == 0)
[...]
+	else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#460: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:930:
+	else {

WARNING:LONG_LINE: line over 90 characters
#461: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:931:
+		if (softnic_parser_read_uint32(&p.shared_shaper_id.tc[1], tokens[27]) != 0) {

CHECK:BRACES: braces {} should be used on all arms of this statement
#474: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:944:
+	if (strcmp(tokens[29], "none") == 0)
[...]
+	else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#476: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:946:
+	else {

WARNING:LONG_LINE: line over 90 characters
#477: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:947:
+		if (softnic_parser_read_uint32(&p.shared_shaper_id.tc[2], tokens[29]) != 0) {

CHECK:BRACES: braces {} should be used on all arms of this statement
#490: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:960:
+	if (strcmp(tokens[31], "none") == 0)
[...]
+	else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#492: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:962:
+	else {

WARNING:LONG_LINE: line over 90 characters
#493: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:963:
+		if (softnic_parser_read_uint32(&p.shared_shaper_id.tc[3], tokens[31]) != 0) {

WARNING:LONG_LINE: line over 90 characters
#536: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:4863:
+			cmd_tmgr_hierarchy_default(softnic, tokens, n_tokens, out, out_size);

total: 0 errors, 5 warnings, 8 checks, 510 lines checked