automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Luca Boccassi <bluca@debian.org>
Subject: [dpdk-test-report] |WARNING| pw43718 net/bonding: per-slave intermediate rx ring
Date: Wed, 15 Aug 2018 17:47:30 +0200 (CEST)	[thread overview]
Message-ID: <20180815154730.EBCE237AF@dpdk.org> (raw)
In-Reply-To: <20180815154647.28401-1-bluca@debian.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/43718

_coding style issues_


WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#45: FILE: drivers/net/bonding/rte_eth_bond_api.c:529:
+		unsigned j, count;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#83: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:407:
+	unsigned rx_ring_avail = rte_ring_free_count(internals->rx_ring);

WARNING:LONG_LINE: line over 90 characters
#143: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:463:
+				rte_prefetch0(rte_pktmbuf_mtod(mbuf_bounce[j + 3], void *));

WARNING:LONG_LINE: line over 90 characters
#153: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:471:
+			if (unlikely(is_lacp_packets(hdr->ether_type, subtype, mbuf_bounce[j]) ||

CHECK:BRACES: braces {} should be used on all arms of this statement
#153: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:471:
+			if (unlikely(is_lacp_packets(hdr->ether_type, subtype, mbuf_bounce[j]) ||
[...]
-						(num_rx_total - j));
[...]

WARNING:LONG_LINE: line over 90 characters
#173: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:485:
+					memmove(&mbuf_bounce[j], &mbuf_bounce[j + 1], sizeof(mbuf_bounce[0]) *

total: 0 errors, 5 warnings, 1 checks, 205 lines checked

           reply	other threads:[~2018-08-15 15:47 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20180815154647.28401-1-bluca@debian.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180815154730.EBCE237AF@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=bluca@debian.org \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).