From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id EBCE237AF; Wed, 15 Aug 2018 17:47:30 +0200 (CEST)
In-Reply-To: <20180815154647.28401-1-bluca@debian.org>
References: <20180815154647.28401-1-bluca@debian.org>
To: test-report@dpdk.org
Cc: Luca Boccassi <bluca@debian.org>
Message-Id: <20180815154730.EBCE237AF@dpdk.org>
Date: Wed, 15 Aug 2018 17:47:30 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw43718 net/bonding: per-slave
	intermediate rx ring
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Aug 2018 15:47:31 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/43718

_coding style issues_


WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#45: FILE: drivers/net/bonding/rte_eth_bond_api.c:529:
+		unsigned j, count;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#83: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:407:
+	unsigned rx_ring_avail = rte_ring_free_count(internals->rx_ring);

WARNING:LONG_LINE: line over 90 characters
#143: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:463:
+				rte_prefetch0(rte_pktmbuf_mtod(mbuf_bounce[j + 3], void *));

WARNING:LONG_LINE: line over 90 characters
#153: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:471:
+			if (unlikely(is_lacp_packets(hdr->ether_type, subtype, mbuf_bounce[j]) ||

CHECK:BRACES: braces {} should be used on all arms of this statement
#153: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:471:
+			if (unlikely(is_lacp_packets(hdr->ether_type, subtype, mbuf_bounce[j]) ||
[...]
-						(num_rx_total - j));
[...]

WARNING:LONG_LINE: line over 90 characters
#173: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:485:
+					memmove(&mbuf_bounce[j], &mbuf_bounce[j + 1], sizeof(mbuf_bounce[0]) *

total: 0 errors, 5 warnings, 1 checks, 205 lines checked