From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 60E0558EC; Fri, 17 Aug 2018 06:22:45 +0200 (CEST)
In-Reply-To: <1534479652-80182-3-git-send-email-nikhil.rao@intel.com>
References: <1534479652-80182-3-git-send-email-nikhil.rao@intel.com>
To: test-report@dpdk.org
Cc: Nikhil Rao <nikhil.rao@intel.com>
Message-Id: <20180817042245.60E0558EC@dpdk.org>
Date: Fri, 17 Aug 2018 06:22:45 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw43758 [v2,
	3/4] eventdev: add eth Tx adapter implementation
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Aug 2018 04:22:45 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/43758

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#94: FILE: lib/librte_eventdev/rte_event_eth_tx_adapter.c:43:
+#define RTE_EVENT_ETH_TX_ADAPTER_ID_VALID_OR_ERR_RET(id, retval) \
+do { \
+	if (!txa_valid_id(id)) { \
+		RTE_EDEV_LOG_ERR("Invalid eth Rx adapter id = %d", id); \
+		return retval; \
+	} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#102: FILE: lib/librte_eventdev/rte_event_eth_tx_adapter.c:51:
+#define TXA_CHECK_OR_ERR_RET(id) \
+do {\
+	int ret; \
+	RTE_EVENT_ETH_TX_ADAPTER_ID_VALID_OR_ERR_RET((id), -EINVAL); \
+	ret = txa_init(); \
+	if (ret != 0) \
+		return ret; \
+	if (!txa_adapter_exist((id))) \
+		return -EINVAL; \
+} while (0)

total: 0 errors, 2 warnings, 1183 lines checked