[dpdk-test-report] |WARNING| pw43799 vmxnet3: stats_reset implementation

automatic DPDK test reports
 help / color / mirror / Atom feed

From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: yogev ch <yogev@cgstowernetworks.com>
Subject: [dpdk-test-report] |WARNING| pw43799 vmxnet3: stats_reset implementation
Date: Wed, 22 Aug 2018 09:39:03 +0200 (CEST)	[thread overview]
Message-ID: <20180822073903.3A7274C95@dpdk.org> (raw)
In-Reply-To: <1534923617-55302-1-git-send-email-yogev@cgstowernetworks.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/43799

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <UPT1_TxStats>
#64: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:904:
+					struct UPT1_TxStats *res)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'f' - possible side-effects?
#68: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:908:
+#define VMXNET3_REDUCE_SNAPSHOT_TX_STAT(h, i, f, r)	\
+		((r)->f -= (h)->snapshot_tx_stats[(i)].f)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'f' may be better as '(f)' to avoid precedence issues
#68: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:908:
+#define VMXNET3_REDUCE_SNAPSHOT_TX_STAT(h, i, f, r)	\
+		((r)->f -= (h)->snapshot_tx_stats[(i)].f)

CHECK:CAMELCASE: Avoid CamelCase: <ucastPktsTxOK>
#71: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:911:
+	VMXNET3_REDUCE_SNAPSHOT_TX_STAT(hw, q, ucastPktsTxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <mcastPktsTxOK>
#72: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:912:
+	VMXNET3_REDUCE_SNAPSHOT_TX_STAT(hw, q, mcastPktsTxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <bcastPktsTxOK>
#73: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:913:
+	VMXNET3_REDUCE_SNAPSHOT_TX_STAT(hw, q, bcastPktsTxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <ucastBytesTxOK>
#74: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:914:
+	VMXNET3_REDUCE_SNAPSHOT_TX_STAT(hw, q, ucastBytesTxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <mcastBytesTxOK>
#75: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:915:
+	VMXNET3_REDUCE_SNAPSHOT_TX_STAT(hw, q, mcastBytesTxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <bcastBytesTxOK>
#76: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:916:
+	VMXNET3_REDUCE_SNAPSHOT_TX_STAT(hw, q, bcastBytesTxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <pktsTxError>
#77: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:917:
+	VMXNET3_REDUCE_SNAPSHOT_TX_STAT(hw, q, pktsTxError, res);

CHECK:CAMELCASE: Avoid CamelCase: <pktsTxDiscard>
#78: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:918:
+	VMXNET3_REDUCE_SNAPSHOT_TX_STAT(hw, q, pktsTxDiscard, res);

CHECK:CAMELCASE: Avoid CamelCase: <UPT1_RxStats>
#85: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:925:
+					struct UPT1_RxStats *res)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'f' - possible side-effects?
#89: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:929:
+#define VMXNET3_REDUCE_SNAPSHOT_RX_STAT(h, i, f, r)	\
+		((r)->f -= (h)->snapshot_rx_stats[(i)].f)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'f' may be better as '(f)' to avoid precedence issues
#89: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:929:
+#define VMXNET3_REDUCE_SNAPSHOT_RX_STAT(h, i, f, r)	\
+		((r)->f -= (h)->snapshot_rx_stats[(i)].f)

CHECK:CAMELCASE: Avoid CamelCase: <ucastPktsRxOK>
#92: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:932:
+	VMXNET3_REDUCE_SNAPSHOT_RX_STAT(hw, q, ucastPktsRxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <mcastPktsRxOK>
#93: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:933:
+	VMXNET3_REDUCE_SNAPSHOT_RX_STAT(hw, q, mcastPktsRxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <bcastPktsRxOK>
#94: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:934:
+	VMXNET3_REDUCE_SNAPSHOT_RX_STAT(hw, q, bcastPktsRxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <ucastBytesRxOK>
#95: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:935:
+	VMXNET3_REDUCE_SNAPSHOT_RX_STAT(hw, q, ucastBytesRxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <mcastBytesRxOK>
#96: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:936:
+	VMXNET3_REDUCE_SNAPSHOT_RX_STAT(hw, q, mcastBytesRxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <bcastBytesRxOK>
#97: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:937:
+	VMXNET3_REDUCE_SNAPSHOT_RX_STAT(hw, q, bcastBytesRxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <pktsRxError>
#98: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:938:
+	VMXNET3_REDUCE_SNAPSHOT_RX_STAT(hw, q, pktsRxError, res);

CHECK:CAMELCASE: Avoid CamelCase: <pktsRxOutOfBuf>
#99: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:939:
+	VMXNET3_REDUCE_SNAPSHOT_RX_STAT(hw, q, pktsRxOutOfBuf, res);

CHECK:CAMELCASE: Avoid CamelCase: <txStats>
#110: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:1056:
+		vmxnet3_tx_stats_get(hw, i, &txStats);

CHECK:CAMELCASE: Avoid CamelCase: <rxStats>
#119: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:1073:
+		vmxnet3_rx_stats_get(hw, i, &rxStats);

total: 0 errors, 0 warnings, 24 checks, 129 lines checked

          parent reply	other threads:[~2018-08-22  7:39 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1534923617-55302-1-git-send-email-yogev@cgstowernetworks.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180822073903.3A7274C95@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=test-report@dpdk.org \
    --cc=yogev@cgstowernetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).