automatic DPDK test reports
 help / color / mirror / Atom feed
* [dpdk-test-report] |WARNING| pw43928 [v1] testpmd: add new command for show port info
       [not found] <1535465494-45384-1-git-send-email-emma.finn@intel.com>
@ 2018-08-28 14:12 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2018-08-28 14:12 UTC (permalink / raw)
  To: test-report; +Cc: Emma Finn

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/43928

_coding style issues_


ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files
#32: FILE: app/test-pmd/cmdline.c

ERROR:SPACING: space required after that ',' (ctx:VxV)
#51: FILE: app/test-pmd/cmdline.c:7078:
+			port_summary_display(i,1);
 			                      ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#77: FILE: app/test-pmd/cmdline.c:7144:
+		port_summary_display(res->portnum,0);
 		                                 ^

ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files
#101: FILE: app/test-pmd/config.c

ERROR:SPACING: spaces required around that '==' (ctx:VxV)
#128: FILE: app/test-pmd/config.c:540:
+	if(all==1 && port_id ==0)
 	      ^

ERROR:SPACING: spaces required around that '==' (ctx:WxV)
#128: FILE: app/test-pmd/config.c:540:
+	if(all==1 && port_id ==0)
 	                     ^

ERROR:SPACING: space required before the open parenthesis '('
#128: FILE: app/test-pmd/config.c:540:
+	if(all==1 && port_id ==0)

WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#129: FILE: app/test-pmd/config.c:541:
+		printf("Number of ports: %i 
", port_number);

WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#130: FILE: app/test-pmd/config.c:542:
+	printf("Port %-2d: %02X:%02X:%02X:%02X:%02X:%02X, %s, %s, %s, %u Mbps 
",

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#134: FILE: app/test-pmd/config.c:546:
+		 (link.link_status) ? ("up") : ("down"), (unsigned) link.link_speed);

ERROR:SPACING: space prohibited before that '++' (ctx:WxO)
#151: FILE: app/test-pmd/config.c:806:
+		count ++;
 		      ^

ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files
#162: FILE: app/test-pmd/testpmd.h

total: 9 errors, 3 warnings, 124 lines checked

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2018-08-28 14:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1535465494-45384-1-git-send-email-emma.finn@intel.com>
2018-08-28 14:12 ` [dpdk-test-report] |WARNING| pw43928 [v1] testpmd: add new command for show port info checkpatch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).