From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id B452A4CB9; Tue, 28 Aug 2018 16:12:15 +0200 (CEST)
In-Reply-To: <1535465494-45384-1-git-send-email-emma.finn@intel.com>
References: <1535465494-45384-1-git-send-email-emma.finn@intel.com>
To: test-report@dpdk.org
Cc: Emma Finn <emma.finn@intel.com>
Message-Id: <20180828141215.B452A4CB9@dpdk.org>
Date: Tue, 28 Aug 2018 16:12:15 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw43928 [v1] testpmd: add new command
	for show port info
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Aug 2018 14:12:15 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/43928

_coding style issues_


ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files
#32: FILE: app/test-pmd/cmdline.c

ERROR:SPACING: space required after that ',' (ctx:VxV)
#51: FILE: app/test-pmd/cmdline.c:7078:
+			port_summary_display(i,1);
 			                      ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#77: FILE: app/test-pmd/cmdline.c:7144:
+		port_summary_display(res->portnum,0);
 		                                 ^

ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files
#101: FILE: app/test-pmd/config.c

ERROR:SPACING: spaces required around that '==' (ctx:VxV)
#128: FILE: app/test-pmd/config.c:540:
+	if(all==1 && port_id ==0)
 	      ^

ERROR:SPACING: spaces required around that '==' (ctx:WxV)
#128: FILE: app/test-pmd/config.c:540:
+	if(all==1 && port_id ==0)
 	                     ^

ERROR:SPACING: space required before the open parenthesis '('
#128: FILE: app/test-pmd/config.c:540:
+	if(all==1 && port_id ==0)

WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#129: FILE: app/test-pmd/config.c:541:
+		printf("Number of ports: %i 
", port_number);

WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#130: FILE: app/test-pmd/config.c:542:
+	printf("Port %-2d: %02X:%02X:%02X:%02X:%02X:%02X, %s, %s, %s, %u Mbps 
",

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#134: FILE: app/test-pmd/config.c:546:
+		 (link.link_status) ? ("up") : ("down"), (unsigned) link.link_speed);

ERROR:SPACING: space prohibited before that '++' (ctx:WxO)
#151: FILE: app/test-pmd/config.c:806:
+		count ++;
 		      ^

ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files
#162: FILE: app/test-pmd/testpmd.h

total: 9 errors, 3 warnings, 124 lines checked